Issue 196061: Pull in ICU 4.2.1 with the fix for a memory leak in i18n/timezone.cpp...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 196061: Pull in ICU 4.2.1 with the fix for a memory leak in i18n/timezone.cpp... (Closed)

Created:
11 years, 3 months ago by jungshik at Google

Modified:
9 years, 7 months ago

Reviewers:
Erik does not do reviews

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Pull in ICU 4.2.1 with the fix for a memory leak in i18n/timezone.cpp BUG=8198 TEST=net-purify test passes on Windows TBR=erikkay Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25713

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	DEPS	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik does not do reviews

11 years, 3 months ago (2009-09-09 15:15:16 UTC) #2

LGTM

On Wed, Sep 9, 2009 at 1:08 AM, <jshin@chromium.org> wrote:
> Reviewers: Erik Kay,
>
> Description:
> Pull in ICU 4.2.1 with the fix for a memory leak in i18n/timezone.cpp
>
> BUG=3D8198
> TEST=3Dnet-purify test passes on Windows
> TBR=3Derikkay
>
> Please review this at http://codereview.chromium.org/196061
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
> =A0M =A0 =A0 DEPS
>
>
> Index: DEPS
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- DEPS =A0 =A0 =A0 =A0(revision 25708)
> +++ DEPS =A0 =A0 =A0 =A0(working copy)
> @@ -25,7 +25,7 @@
> =A0 =A0 "/trunk/deps/third_party/WebKit@20601",
>
> =A0 "src/third_party/icu":
> - =A0 =A0"/trunk/deps/third_party/icu42@25651",
> + =A0 =A0"/trunk/deps/third_party/icu42@25712",
>
> =A0 "src/third_party/hunspell":
> =A0 =A0"/trunk/deps/third_party/hunspell128@25668",
>
>
>

Expand Messages | Collapse Messages