Unit test addition, cleanup for render_process/thread.

Unit test addition, cleanup for render_process/thread.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8782

[John Grabowski, 2009-01-28 01:02:05]

Tested explicitly on Mac Win Linux.

[agl, 2009-01-28 01:07:52]

I'm not sure about the webkit_glue mocks as I don't know what Windows does in
the this situation. But, otherwise, LGTM.

http://codereview.chromium.org/19606/diff/241/246
File chrome/renderer/render_process_unittest.cc (right):

http://codereview.chromium.org/19606/diff/241/246#newcode30
Line 30: base::SharedMemory *mem = RenderProcess::AllocSharedMemory(size);
Stars on the left.

[brettw, 2009-01-28 01:18:57]

It seems like we shouldn't have to do something different on different platforms
for these glue functions.

RenderProcess currently has ifdefs for Windows and unit tests for its calls to
these functions, and it looks like you added them. What's your vision for how
this will end up?

[brettw, 2009-01-28 01:46:26]

http://codereview.chromium.org/19606/diff/241/247
File chrome/renderer/render_process.cc (right):

http://codereview.chromium.org/19606/diff/241/247#newcode128
Line 128: std::wstring root_name(L"root");
What does Linux/OSX do if the name is an existing name? I looked up shm_open and
the open group says it is "implementation dependent" which seems kind of scary
to me. We specifically want a different shared memory object for each call,
unique both between all renderers and within this one. This is what the empty
name on Windows means.

[jeremy, 2009-01-28 02:13:15]

lgtm

http://codereview.chromium.org/19606/diff/241/248
File chrome/chrome.xcodeproj/project.pbxproj (right):

http://codereview.chromium.org/19606/diff/241/248#newcode2151
Line 2151: 3380A9AA0F2FC3BF004EF74F /* mock_webkit_glue.cc */,
alphabetize :)

http://codereview.chromium.org/19606/diff/241/247
File chrome/renderer/render_process.cc (right):

http://codereview.chromium.org/19606/diff/241/247#newcode128
Line 128: std::wstring root_name(L"root");
ob-warning: Named POSIX shared memory has bad behavior in that it doesn't go
away when the owning process crashes.