Unit test addition, cleanup for render_process/thread.

chrome/renderer/render_process.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "build/build_config.h"
 
 #if defined(OS_WIN)
 #include <windows.h>
 #include <objidl.h>
 #include <mlang.h>
@@ skipping 54 matching lines @@
             "GdiInitializeLanguagePack"));
     DCHECK(gdi_init_lpk);
     if (gdi_init_lpk) {
       gdi_init_lpk(0);
     }
   }
 #endif
 
   const CommandLine& command_line = *CommandLine::ForCurrentProcess();
   if (command_line.HasSwitch(switches::kJavaScriptFlags)) {
-  // TODO(port)
-  // Try and limit what we pull in for our non-Win unit test bundle
-#if defined(OS_WIN) || (!defined(UNIT_TEST))
     webkit_glue::SetJavaScriptFlags(
       command_line.GetSwitchValue(switches::kJavaScriptFlags));
-#endif
   }
   if (command_line.HasSwitch(switches::kPlaybackMode) ||
       command_line.HasSwitch(switches::kRecordMode)) {
-  // TODO(port)
-  // Try and limit what we pull in for our non-Win unit test bundle
-#if defined(OS_WIN) || (!defined(UNIT_TEST))
       webkit_glue::SetRecordPlaybackMode(true);
-#endif
   }
 
   if (command_line.HasSwitch(switches::kInProcessPlugins) ||
       command_line.HasSwitch(switches::kSingleProcess))
     load_plugins_in_process_ = true;
 
   if (command_line.HasSwitch(switches::kEnableWatchdog)) {
     // TODO(JAR): Need to implement renderer IO msgloop watchdog.
   }
 
@@ skipping 23 matching lines @@
   ChildProcess::GlobalCleanup();
 }
 
 // static
 bool RenderProcess::ShouldLoadPluginsInProcess() {
   return load_plugins_in_process_;
 }
 
 // static
 base::SharedMemory* RenderProcess::AllocSharedMemory(size_t size) {
+#if defined(OS_LINUX)
+  // Linux has trouble with ""; the Create() call below will fail when
+  // triggered by RenderProcessTest.TestSharedMemoryAllocOne(), every
+  // time.
+  std::wstring root_name(L"root");

[brettw, 2009/01/28 01:46:27]

What does Linux/OSX do if the name is an existing name? I looked up shm_open and
the open group says it is "implementation dependent" which seems kind of scary
to me. We specifically want a different shared memory object for each call,
unique both between all renderers and within this one. This is what the empty
name on Windows means.

[jeremy, 2009/01/28 02:13:15]

ob-warning: Named POSIX shared memory has bad behavior in that it doesn't go
away when the owning process crashes.

+#else
+  std::wstring root_name(L"");
+#endif
+
   self()->clearer_factory_.RevokeAll();
 
   base::SharedMemory* mem = self()->GetSharedMemFromCache(size);
   if (mem)
     return mem;
 
   // Round-up size to allocation granularity
   size_t allocation_granularity = base::SysInfo::VMAllocationGranularity();
   size = size / allocation_granularity + 1;
   size = size * allocation_granularity;
 
   mem = new base::SharedMemory();
   if (!mem)
     return NULL;
-  if (!mem->Create(L"", false, true, size)) {
+  if (!mem->Create(root_name, false, true, size)) {
     delete mem;
     return NULL;
   }
 
   return mem;
 }
 
 // static
 void RenderProcess::FreeSharedMemory(base::SharedMemory* mem) {
   if (self()->PutSharedMemInCache(mem)) {
@@ skipping 57 matching lines @@
   clearer_factory_.RevokeAll();
 
   MessageLoop::current()->PostDelayedTask(FROM_HERE,
       clearer_factory_.NewRunnableMethod(&RenderProcess::ClearSharedMemCache),
       5000 /* 5 seconds */);
 }
 
 void RenderProcess::Cleanup() {
   // TODO(port)
   // Try and limit what we pull in for our non-Win unit test bundle
-#if defined(OS_WIN) || (!defined(UNIT_TEST))
 #ifndef NDEBUG
   // log important leaked objects
   webkit_glue::CheckForLeaks();
 #endif
-#endif
 }