Fix the windows allocator to behave properly on realloc....

Fix the windows allocator to behave properly on realloc.

The spec says that calling realloc(ptr, 0) should free ptr
and return NULL.


BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25612

[jar (doing other things), 2009-09-08 07:41:13]

LGTM

nit: I didn't see the reason for re-ordering free vs realloc.  It tended to make
the CL a little harder to read.  I like the var name changes (to avoid
one-letter-names), but the diff would have been more obvious without the
re-ordering.  If you have a reason (it matches structure in other code?), then
it is fine.  If not, you might want to preserve order of functions.

[mbelshe, 2009-09-08 07:48:50]

Thanks for checking.
The reason for the reordering was because I changed from calling free() to
win_heap_free(), and if I didn't reorder, then it wasn't declared before
using it, and you get a compile error.
Mike


On Tue, Sep 8, 2009 at 12:41 AM, <jar@chromium.org> wrote:

> LGTM
>
> nit: I didn't see the reason for re-ordering free vs realloc.  It tended
> to make the CL a little harder to read.  I like the var name changes (to
> avoid one-letter-names), but the diff would have been more obvious
> without the re-ordering.  If you have a reason (it matches structure in
> other code?), then it is fine.  If not, you might want to preserve order
> of functions.
>
>
> http://codereview.chromium.org/196041
>

[jar (doing other things), 2009-09-08 16:11:33]

LGTM