Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1952002: AutoFill profile shouldn't be saved when cancelled during initial setup. (Closed)

Created:
10 years, 7 months ago by dhollowa
Modified:
9 years, 7 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, John Grabowski, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

AutoFill profile shouldn't be saved when cancelled during initial setup. Relanding after revert of: 46424 http://codereview.chromium.org/1902003 Fixing compile error on Windows. For first encounter with fillable form, the AutoFillManager::OnInfoBarAccepted() call now passes the new profile and credit card information to the dialog directly instead of saving it to the database and then invoking the dialog. This facilitates "Cancel" in the dialog where the new information is not persisted. This was a good opportunity to refactor the deferred PersonalDataManager::Observer() logic out of the preferences dialog and into the AutoFillDialogController itself. This also consolidates the Windows, Mac, and Linux interfaces for the ShowAutoFillDialog() call. More work is required on Linux and Windows to properly conform to this interface and fix bug 41010. The Linux and Windows implementations will need to respect the new input parameters |imported_profile| and |imported_credit_card|. BUG=41010 TEST=AutoFillDialogControllerTest.WaitForDataToLoad, AutoFillDialogControllerTest.ImportedParameters Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46430

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+462 lines, -281 lines) Patch
M chrome/browser/autofill/autofill_dialog.h View 1 chunk +12 lines, -10 lines 0 comments Download
M chrome/browser/autofill/autofill_dialog_controller_mac.h View 4 chunks +25 lines, -12 lines 0 comments Download
M chrome/browser/autofill/autofill_dialog_controller_mac.mm View 8 chunks +136 lines, -28 lines 0 comments Download
M chrome/browser/autofill/autofill_dialog_controller_mac_unittest.mm View 23 chunks +218 lines, -60 lines 0 comments Download
M chrome/browser/autofill/autofill_dialog_gtk.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M chrome/browser/autofill/autofill_dialog_mac.mm View 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/autofill/autofill_manager.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/autofill/autofill_manager.cc View 3 chunks +12 lines, -35 lines 0 comments Download
M chrome/browser/autofill/personal_data_manager.h View 3 chunks +14 lines, -4 lines 0 comments Download
M chrome/browser/autofill/personal_data_manager.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/browser_test_helper.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/preferences_window_controller.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/cocoa/preferences_window_controller.mm View 3 chunks +1 line, -108 lines 0 comments Download
M chrome/browser/gtk/options/content_page_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/autofill_profiles_view_win.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M chrome/browser/views/options/content_page_view.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
dhollowa
10 years, 7 months ago (2010-05-05 02:15:49 UTC) #1
James Hawkins
10 years, 7 months ago (2010-05-05 02:17:53 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698