Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 1902003: Revert 46424 - AutoFill profile shouldn't be saved when cancelled during init... (Closed)

Created:
10 years, 7 months ago by dhollowa
Modified:
9 years, 7 months ago
Reviewers:
dhollowa
CC:
chromium-reviews, John Grabowski, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Revert 46424 - AutoFill profile shouldn't be saved when cancelled during initial setup. For first encounter with fillable form, the AutoFillManager::OnInfoBarAccepted() call now passes the new profile and credit card information to the dialog directly instead of saving it to the database and then invoking the dialog. This facilitates "Cancel" in the dialog where the new information is not persisted. This was a good opportunity to refactor the deferred PersonalDataManager::Observer() logic out of the preferences dialog and into the AutoFillDialogController itself. This also consolidates the Windows, Mac, and Linux interfaces for the ShowAutoFillDialog() call. More work is required on Linux and Windows to properly conform to this interface and fix bug 41010. The Linux and Windows implementations will need to respect the new input parameters |imported_profile| and |imported_credit_card|. BUG=41010 TEST=AutoFillDialogControllerTest.WaitForDataToLoad, AutoFillDialogControllerTest.ImportedParameters Review URL: http://codereview.chromium.org/1930002 TBR=dhollowa@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46426

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+280 lines, -459 lines) Patch
M chrome/browser/autofill/autofill_dialog.h View 1 chunk +10 lines, -12 lines 0 comments Download
M chrome/browser/autofill/autofill_dialog_controller_mac.h View 4 chunks +12 lines, -25 lines 0 comments Download
M chrome/browser/autofill/autofill_dialog_controller_mac.mm View 8 chunks +28 lines, -136 lines 0 comments Download
M chrome/browser/autofill/autofill_dialog_controller_mac_unittest.mm View 23 chunks +60 lines, -218 lines 0 comments Download
M chrome/browser/autofill/autofill_dialog_gtk.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M chrome/browser/autofill/autofill_dialog_mac.mm View 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/autofill/autofill_manager.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/autofill/autofill_manager.cc View 3 chunks +35 lines, -12 lines 0 comments Download
M chrome/browser/autofill/personal_data_manager.h View 3 chunks +4 lines, -14 lines 0 comments Download
M chrome/browser/autofill/personal_data_manager.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M chrome/browser/cocoa/browser_test_helper.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/preferences_window_controller.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/preferences_window_controller.mm View 3 chunks +108 lines, -1 line 0 comments Download
M chrome/browser/gtk/options/content_page_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/autofill_profiles_view_win.cc View 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
dhollowa
10 years, 7 months ago (2010-05-05 01:14:59 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698