Issue 195093: handle mole/toolstrip URLs properly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 195093: handle mole/toolstrip URLs properly (Closed)

Created:
11 years, 3 months ago by Erik does not do reviews

Modified:
9 years, 7 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Handle mole/toolstrip URLs properly. * expand/collapse to chrome-extension://crashme no longer crashes * expand/collapse to a relative URL now works BUG=20412, 21905 TEST=browser_tests ExtensionApi.Toolstrip (note that the test doesn't actually exercise these changes due to 21905) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26266

Patch Set 1 #

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+98 lines, -9 lines)			Patch
M	chrome/browser/extensions/extension_host.cc	View	2 chunks	+28 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_toolstrip_api.cc	View	3 chunks	+23 lines, -5 lines	1 comment	Download
A	chrome/test/data/extensions/api_test/toolstrip/folder/relative.html	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/toolstrip/manifest.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/toolstrip/test.html	View	1 chunk	+29 lines, -1 line	0 comments	Download
A	chrome/test/data/extensions/api_test/toolstrip/test2.html	View	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Matt Perry

LGTM http://codereview.chromium.org/195093/diff/1/3 File chrome/browser/extensions/extension_toolstrip_api.cc (right): http://codereview.chromium.org/195093/diff/1/3#newcode39 Line 39: static GURL ResolveURLForExtension(const std::string& url_string, I think ...

11 years, 3 months ago (2009-09-15 20:31:57 UTC) #2

Erik does not do reviews

11 years, 3 months ago (2009-09-15 20:40:39 UTC) #3

On Tue, Sep 15, 2009 at 1:31 PM,  <mpcomplete@chromium.org> wrote:
> LGTM
>
>
> http://codereview.chromium.org/195093/diff/1/3
> File chrome/browser/extensions/extension_toolstrip_api.cc (right):
>
> http://codereview.chromium.org/195093/diff/1/3#newcode39
> Line 39: static GURL ResolveURLForExtension(const std::string&
> url_string,
> I think Resolve works on absolute URLs too, so this whole function can
> be replaced with current_url.Resolve(url_string).

Ahh, you're right.  I missed that in the comments.  Thanks!

Erik

>
> http://codereview.chromium.org/195093
>

Expand Messages | Collapse Messages