Issue 195091: s/NDEBUG/NVALGRIND/g in base/dynamic_annotations.* to allow...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 195091: s/NDEBUG/NVALGRIND/g in base/dynamic_annotations.* to allow... (Closed)

Created:
11 years, 3 months ago by Timur Iskhodzhanov

Modified:
9 years, 6 months ago

Reviewers:
Dean McNamee, dank

CC:
chromium-reviews_googlegroups.com, brettw

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

s/NDEBUG/NVALGRIND/g in base/dynamic_annotations.* to allow ThreadSanitizer runs on release binaries. This is a copy of http://codereview.chromium.org/201060 I wasn't a commiter at that time. Please note that http://codereview.chromium.org/195078 was submitted recently which defines NVALGRIND for non-valgrind Release builds. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26576

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -11 lines)			Patch
	M	base/dynamic_annotations.h	View	1 2	3 chunks	+7 lines, -8 lines	0 comments	Download
	M	base/dynamic_annotations.cc	View	1 2	2 chunks	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Timur Iskhodzhanov

Hi Dan, Dean, Can you please review this changelist? Thank you, Timur Iskhodzhanov

11 years, 3 months ago (2009-09-15 18:51:00 UTC) #1

Dean McNamee

But I am still alive. I missed why you didn't invert the define logic. I ...

11 years, 3 months ago (2009-09-15 20:40:47 UTC) #3

dkegel

11 years, 3 months ago (2009-09-15 20:42:17 UTC) #4

It's at least the way you want it at the gyp level, and
since we do all our builds via gyp, it ought to be hard to screw up.


I am glad to hear you're still alive :-)

On Tue, Sep 15, 2009 at 1:40 PM, Dean McNamee <deanm@chromium.org> wrote:
> But I am still alive.
>
> I missed why you didn't invert the define logic. =A0I guess it's how
> NDEBUG works, but I also sort of think of that as fragile also...
>
> On Tue, Sep 15, 2009 at 8:54 PM, =A0<dank@chromium.org> wrote:
>> Dean's no longer at Google.
>>
>> LGTM (but do update the wiki).
>>
>>
>> http://codereview.chromium.org/195091
>>
>

Expand Messages | Collapse Messages