Use MAKEPOINTS instead of GET_X/Y_LPARAM to reduce a dependency on ATL....

Use gfx::Point instead of GET_X/Y_LPARAM to reduce a dependency on ATL.

BUG=5027
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25788

[Peter Kasting, 2009-09-09 17:51:40]

GET_X_LPARAM is defined in windowsx.h, not atlapp.h, from what I read on MSDN. 
Can we just change the #include?  I think it's clearer and safer the way it is.

[James Hawkins, 2009-09-09 19:11:57]

On 2009/09/09 17:51:40, Peter Kasting wrote:
> GET_X_LPARAM is defined in windowsx.h, not atlapp.h, from what I read on MSDN.

> Can we just change the #include?  I think it's clearer and safer the way it
is.

windowsx.h pollutes the namespace.  For example, if we include windowsx.h we get
the macros IsMaximized(hwnd) and IsMinimized(hwnd), which conflicts with a
parameter-less method of the same name in views/window/window.h.

[Peter Kasting, 2009-09-09 19:15:07]

On Wed, Sep 9, 2009 at 12:11 PM, <jhawkins@chromium.org> wrote:

> windowsx.h pollutes the namespace.  For example, if we include
> windowsx.h we get the macros IsMaximized(hwnd) and IsMinimized(hwnd),
> which conflicts with a parameter-less method of the same name in
> views/window/window.h.


Yeah, but we already have to do things like #undef MAX/MIN for similar
Windows issues.  I guess it doesn't matter too much, this new code makes me
sad though.

http://codereview.chromium.org/195035
>

[Peter Kasting, 2009-09-09 20:18:18]

LGTM, this approach seems cleaner.

http://codereview.chromium.org/195035/diff/3004/2008
File base/gfx/point.h (right):

http://codereview.chromium.org/195035/diff/3004/2008#newcode29
Line 29: explicit Point(DWORD point);
Nit: I'd add a comment about where this DWORD should come from (it's not
immediately obvious how a DWORD is a point).

http://codereview.chromium.org/195035/diff/3004/2005
File views/controls/tree/tree_view.cc (right):

http://codereview.chromium.org/195035/diff/3004/2005#newcode730
Line 730: hit_info.pt = point.ToPOINT();
Nit: I would just do "hit_info.pt = gfx::Point(l_param).ToPOINT();"

[James Hawkins, 2009-09-09 20:26:21]

http://codereview.chromium.org/195035/diff/3004/2008
File base/gfx/point.h (right):

http://codereview.chromium.org/195035/diff/3004/2008#newcode29
Line 29: explicit Point(DWORD point);
On 2009/09/09 20:18:18, Peter Kasting wrote:
> Nit: I'd add a comment about where this DWORD should come from (it's not
> immediately obvious how a DWORD is a point).

Done.

http://codereview.chromium.org/195035/diff/3004/2005
File views/controls/tree/tree_view.cc (right):

http://codereview.chromium.org/195035/diff/3004/2005#newcode730
Line 730: hit_info.pt = point.ToPOINT();
On 2009/09/09 20:18:18, Peter Kasting wrote:
> Nit: I would just do "hit_info.pt = gfx::Point(l_param).ToPOINT();"

Done.