Rebaseline more of fast/repaint tests we are now passing....

Rebaseline more of fast/repaint tests we are now passing.

The difference between repaint areas is due to the difference in repaint logic. Safari/Mac port uses NSView's native 
rectangle collection/unification, and we just unify all into one damage rect.


R=jparent
BUG=8630
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25728

[Julie Parent, 2009-09-08 22:28:18]

Wow, failingLayoutTests--!

Only thing I noticed is that
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/focus-ring-expected.png
didn't have a corresponding checksum, was that intentional?

LGTM

[ojan, 2009-09-08 22:39:07]

Drive-by: Ditto my comment on the previous review. Please include a
description of why we don't match upstream. This will make future layout
test fixing work easier when looking over the history of rebaselines.

On Tue, Sep 8, 2009 at 3:13 PM, <dglazkov@chromium.org> wrote:

>
> Reviewers: Julie Parent,
>
> Description:
> Rebaseline more of fast/repaint tests we are now passing.
>
> R=jparent
> BUG=8630
> TEST=none
>
>
> Please review this at http://codereview.chromium.org/195028
>
> SVN Base: svn://chrome-svn.corp.google.com/chrome/trunk/src/
>
> Affected files:
>  A
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/control-clip-expected.checksum
>  A
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/control-clip-expected.png
>  A
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/control-clip-expected.txt
>  A
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/create-layer-repaint-expected.checksum
>  A
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/create-layer-repaint-expected.png
>  A
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/delete-into-nested-block-expected.checksum
>  A
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/delete-into-nested-block-expected.png
>  A
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/dynamic-table-vertical-alignment-change-expected.checksum
>  A
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/dynamic-table-vertical-alignment-change-expected.png
>  A
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/fixed-expected.checksum
>  A
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/fixed-expected.png
>  A
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/flexible-box-overflow-expected.checksum
>  A
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/flexible-box-overflow-expected.png
>  A
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/flexible-box-overflow-horizontal-expected.checksum
>  A
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/flexible-box-overflow-horizontal-expected.png
>  A
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/float-in-new-block-with-layout-delta-expected.checksum
>  A
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/float-in-new-block-with-layout-delta-expected.png
>  A
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/float-move-during-layout-expected.checksum
>  A
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/float-move-during-layout-expected.png
>  A
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/float-new-in-block-expected.checksum
>  A
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/float-new-in-block-expected.png
>  A
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/float-overflow-expected.checksum
>  A
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/float-overflow-expected.png
>  A
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/float-overflow-right-expected.checksum
>  A
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/float-overflow-right-expected.png
>  A
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/focus-layers-expected.checksum
>  A
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/focus-layers-expected.png
>  A
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/focus-ring-expected.png
>  A
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/inline-block-overflow-expected.checksum
>  A
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/inline-block-overflow-expected.png
>  A
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/inline-color-change-expected.checksum
>  A
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/inline-color-change-expected.png
>  A
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/inline-outline-repaint-expected.checksum
>  A
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/inline-outline-repaint-expected.png
>  A
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/intermediate-layout-position-clip-expected.checksum
>  A
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/intermediate-layout-position-clip-expected.png
>  A
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/intermediate-layout-position-expected.checksum
>  A
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/intermediate-layout-position-expected.png
>  A
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/layer-child-outline-expected.checksum
>  A
>
webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/repaint/layer-child-outline-expected.png
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/control-clip-expected.checksum
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/control-clip-expected.png
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/control-clip-expected.txt
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/create-layer-repaint-expected.checksum
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/create-layer-repaint-expected.png
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/create-layer-repaint-expected.txt
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/delete-into-nested-block-expected.checksum
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/delete-into-nested-block-expected.png
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/delete-into-nested-block-expected.txt
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/dynamic-table-vertical-alignment-change-expected.checksum
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/dynamic-table-vertical-alignment-change-expected.png
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/dynamic-table-vertical-alignment-change-expected.txt
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/fixed-expected.checksum
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/fixed-expected.png
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/fixed-expected.txt
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/flexible-box-overflow-expected.checksum
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/flexible-box-overflow-expected.png
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/flexible-box-overflow-expected.txt
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/flexible-box-overflow-horizontal-expected.checksum
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/flexible-box-overflow-horizontal-expected.png
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/flexible-box-overflow-horizontal-expected.txt
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/float-in-new-block-with-layout-delta-expected.checksum
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/float-in-new-block-with-layout-delta-expected.png
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/float-move-during-layout-expected.checksum
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/float-move-during-layout-expected.png
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/float-move-during-layout-expected.txt
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/float-new-in-block-expected.checksum
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/float-new-in-block-expected.png
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/float-overflow-expected.checksum
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/float-overflow-expected.png
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/float-overflow-expected.txt
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/float-overflow-right-expected.checksum
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/float-overflow-right-expected.png
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/float-overflow-right-expected.txt
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/focus-layers-expected.checksum
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/focus-layers-expected.png
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/focus-layers-expected.txt
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/focus-ring-expected.checksum
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/focus-ring-expected.png
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/inline-block-overflow-expected.checksum
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/inline-block-overflow-expected.png
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/inline-block-overflow-expected.txt
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/inline-color-change-expected.checksum
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/inline-color-change-expected.png
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/inline-color-change-expected.txt
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/inline-outline-repaint-expected.checksum
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/inline-outline-repaint-expected.png
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/inline-outline-repaint-expected.txt
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/intermediate-layout-position-clip-expected.checksum
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/intermediate-layout-position-clip-expected.png
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/intermediate-layout-position-expected.checksum
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/intermediate-layout-position-expected.png
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/layer-child-outline-expected.checksum
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/layer-child-outline-expected.png
>  A
>
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/repaint/layer-child-outline-expected.txt
>  M     webkit/tools/layout_tests/test_expectations.txt
>
>
>

[dglazkov, 2009-09-08 23:39:09]

I am guessing this is the result of the rebaseline tool now deduping equivalent
files?

[Julie Parent, 2009-09-08 23:50:27]

It caught my attention because there was a png in both windows and linux
directories, but only a checksum in one.  If the checksums matched, wouldn't
the pngs too?
On Tue, Sep 8, 2009 at 4:39 PM, <dglazkov@chromium.org> wrote:

> I am guessing this is the result of the rebaseline tool now deduping
> equivalent files?
>
>
> http://codereview.chromium.org/195028
>

[dglazkov, 2009-09-09 16:11:41]

Thanks for checking this out Julie! I will now always send these reviews to you.
Turns out, I wasn't running the rebaseline tool correctly (didn't have a
compiled image diff binary), so I had a few extraneous pngs in this CL. I
removed them after examining each by hand.