Issue 195015: Support stepping into CallFunction stubs

Issue 195015: Support stepping into CallFunction stubs (Closed)

Created:
11 years, 3 months ago by yurys

Modified:
9 years, 7 months ago

Reviewers:
sgjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Support stepping in functions called using CallFunction stub. When Debug::PrepareStep is called to prepare 'step in' and current code target is CallFunction stub, the debugger will find function being called on the expression stack and flood it with one shot breakpoints. BreakLocationIterator changed to treat 'debugger;' statements as a possible break location. Since 'debugger;' statement should always invoke debugger it is hanled in a special way. Related Chromium issue: http://code.google.com/p/chromium/issues/detail?id=17978 Committed: http://code.google.com/p/v8/source/detail?r=2830

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+258 lines, -8 lines)			Patch
M	src/debug.h	View	1 2 3	2 chunks	+3 lines, -0 lines	0 comments	Download
M	src/debug.cc	View	1 2 3 4	14 chunks	+123 lines, -6 lines	0 comments	Download
M	test/mjsunit/debug-step-stub-callfunction.js	View	1 2 3	2 chunks	+16 lines, -2 lines	0 comments	Download
A	test/mjsunit/debug-stepin-call-function-stub.js	View	1 2 3 4	1 chunk	+115 lines, -0 lines	0 comments	Download
M	test/mjsunit/mjsunit.status	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sgjesse_gmail.com

LGTM http://codereview.chromium.org/195015/diff/6001/6006 File src/debug.cc (right): http://codereview.chromium.org/195015/diff/6001/6006#newcode79 Line 79: // this stub to detect debugger calls ...

11 years, 3 months ago (2009-09-07 06:42:52 UTC) #2

yurys

11 years, 3 months ago (2009-09-07 07:06:52 UTC) #3

http://codereview.chromium.org/195015/diff/6001/6006
File src/debug.cc (right):

http://codereview.chromium.org/195015/diff/6001/6006#newcode79
Line 79: // this stub to detect debugger calls generated from debugger;
statements.
On 2009/09/07 06:42:52, sgjesse wrote:
> Please remove the ;

Done.

http://codereview.chromium.org/195015/diff/6001/6006#newcode364
Line 364: #ifdef DEBUG
On 2009/09/07 06:42:52, sgjesse wrote:
> Please add a comment to why this #ifdef is intended.

Done.

http://codereview.chromium.org/195015/diff/6001/6006#newcode1208
Line 1208: // Find out number of arguments from the stub minor key.
On 2009/09/07 06:42:52, sgjesse wrote:
> Please make a comment about the argc in the stub is the number of arguments
> passed - not the expected arguments of the called function.

Done.

http://codereview.chromium.org/195015/diff/6001/6004
File test/mjsunit/debug-stepin-call-function-stub.js (right):

http://codereview.chromium.org/195015/diff/6001/6004#newcode85
Line 85: for (var i = 0; i < 2; i++) {
On 2009/09/07 06:42:52, sgjesse wrote:
> Please change this to 3 as IC's does not kick in until after the second call.

Done.

http://codereview.chromium.org/195015/diff/6001/6004#newcode101
Line 101: for (var i = 0; i < 2; i++) {
On 2009/09/07 06:42:52, sgjesse wrote:
> Ditto.

Done.

Expand Messages | Collapse Messages