Further updates to factory installer

Further updates to factory installer

[Nick Sanders, 2010-05-05 08:52:41]

See http://codereview.chromium.org/1945004
Move factory install shim into an overlay install on an existing image.

[anush, 2010-05-05 18:02:42]

http://codereview.chromium.org/1946004/diff/4001/5001
File chromeos-base/chromeos-factoryinstall/chromeos-factoryinstall-0.0.1.ebuild
(right):

http://codereview.chromium.org/1946004/diff/4001/5001#newcode64
chromeos-base/chromeos-factoryinstall/chromeos-factoryinstall-0.0.1.ebuild:64:
"${ROOT}/sbin/chromeos_startup"
Drive by review. It is a bad idea for one ebuild to add/remove/modify files
generated/maintained by another ebuild. It will fail to work in a sandbox.  It
may be more appropriate to pass a flag and make the owner of these
files(chromeos-init) "do the right thing" for factory installs.

[sosa, 2010-05-05 19:27:37]

lgtm (but hold out for cmasone or adlr's lgtm)

I prefer the encapsulation of the factory changes to the base system in the
postinst rather than in customize_rootfs or through a chromeos_init use flag.  I
believe postinst aren't run within the sandbox and that is the purpose of
postinst.  It also makes it much easier to say take a dev image, and convert it
to a factory image (i.e. mount_gpt_image + emerge-x86-generic --root /tmp/m
factory-install) rather than have to build the right thing from scratch the
first time around.

Adding cmasone here as a second check.

[adlr, 2010-05-05 21:51:27]

LGTM

[Chris Masone, 2010-05-05 22:29:22]

http://codereview.chromium.org/1946004/diff/4001/5001
File chromeos-base/chromeos-factoryinstall/chromeos-factoryinstall-0.0.1.ebuild
(right):

http://codereview.chromium.org/1946004/diff/4001/5001#newcode64
chromeos-base/chromeos-factoryinstall/chromeos-factoryinstall-0.0.1.ebuild:64:
"${ROOT}/sbin/chromeos_startup"
+1
On 2010/05/05 18:02:42, anush wrote:
> Drive by review. It is a bad idea for one ebuild to add/remove/modify files
> generated/maintained by another ebuild. It will fail to work in a sandbox.  It
> may be more appropriate to pass a flag and make the owner of these
> files(chromeos-init) "do the right thing" for factory installs.