Allow factory install shim to be overlay installed

Allow factory install shim to be overlay installed

Make standalone package for factory install, so it can be overlayed on top of an existing image.
Modify mod_image_for_test to do the overlay.

[Nick Sanders, 2010-05-05 08:45:21]

Note there's still some debugging stuff, also see
http://codereview.chromium.org/1946004.

Is this a reasonable place for the installer? Is it worthwhile to pull out the
image modification stuff into "overlay_ebuild.sh" or something?

[sosa, 2010-05-05 19:32:02]

http://codereview.chromium.org/1945004/diff/1/5
File src/scripts/image_to_usb.sh (right):

http://codereview.chromium.org/1945004/diff/1/5#newcode45
src/scripts/image_to_usb.sh:45: exit 1
There is a growing amount of logic for factory install in image_to_usb.  Can we
move factory install and mod_image_for_Test logic outside of here or will it be
too inconvenient.

[Nick Sanders, 2010-05-05 21:36:03]

On 2010/05/05 19:32:02, sosa wrote:
> There is a growing amount of logic for factory install in image_to_usb.  Can
we
> move factory install and mod_image_for_Test logic outside of here or will it
be
> too inconvenient.

I don't like it there either, I'll break it out into a separate file.

[sosa, 2010-05-05 21:48:12]

This CL or another?

On Wed, May 5, 2010 at 2:36 PM,  <nsanders@chromium.org> wrote:
> On 2010/05/05 19:32:02, sosa wrote:
>>
>> There is a growing amount of logic for factory install in image_to_usb.
>>  Can
>
> we
>>
>> move factory install and mod_image_for_Test logic outside of here or will
>> it
>
> be
>>
>> too inconvenient.
>
> I don't like it there either, I'll break it out into a separate file.
>
> http://codereview.chromium.org/1945004/show
>

[Nick Sanders, 2010-05-05 22:05:35]

Hmm, another one, since this one is already touching more stuff than optimal for
a single CL.

On 2010/05/05 21:48:12, sosa wrote:
> This CL or another?
> 
> On Wed, May 5, 2010 at 2:36 PM,  <mailto:nsanders@chromium.org> wrote:
> > On 2010/05/05 19:32:02, sosa wrote:
> >>
> >> There is a growing amount of logic for factory install in image_to_usb.
> >> &nbsp;Can
> >
> > we
> >>
> >> move factory install and mod_image_for_Test logic outside of here or will
> >> it
> >
> > be
> >>
> >> too inconvenient.
> >
> > I don't like it there either, I'll break it out into a separate file.
> >
> > http://codereview.chromium.org/1945004/show
> >
>

[sosa, 2010-05-05 22:29:44]

lgtm

On Wed, May 5, 2010 at 3:05 PM,  <nsanders@chromium.org> wrote:
> Hmm, another one, since this one is already touching more stuff than optimal
> for
> a single CL.
>
> On 2010/05/05 21:48:12, sosa wrote:
>>
>> This CL or another?
>
>> On Wed, May 5, 2010 at 2:36 PM,  <mailto:nsanders@chromium.org> wrote:
>> > On 2010/05/05 19:32:02, sosa wrote:
>> >>
>> >> There is a growing amount of logic for factory install in image_to_usb.
>> >> &nbsp;Can
>> >
>> > we
>> >>
>> >> move factory install and mod_image_for_Test logic outside of here or
>> >> will
>> >> it
>> >
>> > be
>> >>
>> >> too inconvenient.
>> >
>> > I don't like it there either, I'll break it out into a separate file.
>> >
>> > http://codereview.chromium.org/1945004/show
>> >
>
>
>
>
> http://codereview.chromium.org/1945004/show
>