Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 194109: linux: drop NOTIMPLEMENTED in GotFocus() (Closed)

Created:
11 years, 3 months ago by Evan Martin
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

linux: drop NOTIMPLEMENTED in GotFocus() Leftover cruft.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/tab_contents/tab_contents_view_gtk.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Evan Martin
i read the windows code and i think we're ok
11 years, 3 months ago (2009-09-14 23:54:14 UTC) #1
Evan Stade
what about mac? I bet they don't want it either. As for views linux, we ...
11 years, 3 months ago (2009-09-15 00:09:35 UTC) #2
Evan Martin
On 2009/09/15 00:09:35, Evan Stade wrote: > That said I think the easiest thing to ...
11 years, 3 months ago (2009-09-15 00:13:06 UTC) #3
Evan Stade
ok then, this lgtm. Maybe ping Avi to do the same for tab_contents_view_mac (I think ...
11 years, 3 months ago (2009-09-15 00:18:03 UTC) #4
Evan Martin
avi: mac probably wants the same thing, leaving at your discretion
11 years, 3 months ago (2009-09-15 00:24:00 UTC) #5
Avi (use Gerrit)
11 years, 3 months ago (2009-09-15 13:48:45 UTC) #6
On 2009/09/15 00:24:00, Evan Martin wrote:
> avi: mac probably wants the same thing, leaving at your discretion

Thanks for the heads-up; will look into doing it.

Powered by Google App Engine
This is Rietveld 408576698