Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Side by Side Diff: chrome/browser/tab_contents/tab_contents_view_gtk.cc

Issue 194109: linux: drop NOTIMPLEMENTED in GotFocus() (Closed)
Patch Set: Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/tab_contents/tab_contents_view_gtk.h" 5 #include "chrome/browser/tab_contents/tab_contents_view_gtk.h"
6 6
7 #include <gdk/gdk.h> 7 #include <gdk/gdk.h>
8 #include <gdk/gdkkeysyms.h> 8 #include <gdk/gdkkeysyms.h>
9 #include <gtk/gtk.h> 9 #include <gtk/gtk.h>
10 10
(...skipping 530 matching lines...) Expand 10 before | Expand all | Expand 10 after
541 gtk_widget_grab_focus(focus_store_.widget()); 541 gtk_widget_grab_focus(focus_store_.widget());
542 else 542 else
543 SetInitialFocus(); 543 SetInitialFocus();
544 } 544 }
545 545
546 void TabContentsViewGtk::UpdateDragCursor(WebDragOperation operation) { 546 void TabContentsViewGtk::UpdateDragCursor(WebDragOperation operation) {
547 drag_dest_->UpdateDragStatus(operation); 547 drag_dest_->UpdateDragStatus(operation);
548 } 548 }
549 549
550 void TabContentsViewGtk::GotFocus() { 550 void TabContentsViewGtk::GotFocus() {
551 NOTIMPLEMENTED(); 551 // This is only used in the views FocusManager stuff but it bleeds through
552 // all subclasses.
552 } 553 }
553 554
554 // This is called when we the renderer asks us to take focus back (i.e., it has 555 // This is called when we the renderer asks us to take focus back (i.e., it has
555 // iterated past the last focusable element on the page). 556 // iterated past the last focusable element on the page).
556 void TabContentsViewGtk::TakeFocus(bool reverse) { 557 void TabContentsViewGtk::TakeFocus(bool reverse) {
557 gtk_widget_child_focus(GTK_WIDGET(GetTopLevelNativeWindow()), 558 gtk_widget_child_focus(GTK_WIDGET(GetTopLevelNativeWindow()),
558 reverse ? GTK_DIR_TAB_BACKWARD : GTK_DIR_TAB_FORWARD); 559 reverse ? GTK_DIR_TAB_BACKWARD : GTK_DIR_TAB_FORWARD);
559 } 560 }
560 561
561 void TabContentsViewGtk::HandleKeyboardEvent( 562 void TabContentsViewGtk::HandleKeyboardEvent(
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
694 gtk_container_child_set_property(GTK_CONTAINER(floating_container), 695 gtk_container_child_set_property(GTK_CONTAINER(floating_container),
695 widget, "x", &value); 696 widget, "x", &value);
696 697
697 int child_y = std::max(half_view_height - (requisition.height / 2), 0); 698 int child_y = std::max(half_view_height - (requisition.height / 2), 0);
698 g_value_set_int(&value, child_y); 699 g_value_set_int(&value, child_y);
699 gtk_container_child_set_property(GTK_CONTAINER(floating_container), 700 gtk_container_child_set_property(GTK_CONTAINER(floating_container),
700 widget, "y", &value); 701 widget, "y", &value);
701 g_value_unset(&value); 702 g_value_unset(&value);
702 } 703 }
703 } 704 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698