Issue 194066: Fix problem of white box appearing in themes without an NTP background image....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 194066: Fix problem of white box appearing in themes without an NTP background image.... (Closed)

Created:
11 years, 3 months ago by Miranda Callahan

Modified:
9 years, 7 months ago

Reviewers:
Glen Murphy, glen

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix problem of white box appearing in themes without an NTP background image. BUG= http://crbug.com/21290 TEST= Install a theme without an NTP image (greyscale). Look at NTP with bookmarkbar attached and detached. See no white box at bottom of NTP. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25861

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -8 lines)			Patch
	M	chrome/browser/browser_theme_provider.cc	View		1 chunk	+7 lines, -0 lines	2 comments	Download
	M	chrome/browser/dom_ui/dom_ui_theme_source.cc	View	1	2 chunks	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Glen Murphy

DOMUIThemeSource fix LGTM. http://codereview.chromium.org/194066/diff/5001/5002 File chrome/browser/browser_theme_provider.cc (right): http://codereview.chromium.org/194066/diff/5001/5002#newcode259 Line 259: resource_names_[IDR_THEME_TOOLBAR] = "theme_toolbar"; Are these ...

11 years, 3 months ago (2009-09-10 04:45:36 UTC) #2

Miranda Callahan

11 years, 3 months ago (2009-09-10 15:28:43 UTC) #3

http://codereview.chromium.org/194066/diff/5001/5002
File chrome/browser/browser_theme_provider.cc (right):

http://codereview.chromium.org/194066/diff/5001/5002#newcode259
Line 259: resource_names_[IDR_THEME_TOOLBAR] = "theme_toolbar";
On 2009/09/10 04:45:36, Glen Murphy wrote:
> Are these meant to be part of this CL?

Yes and no; when I moved the code in DOMUIThemeSource, it exposed a problem with
my change to HasCustomImage -- namely, that THEME_NTP_BACKGROUND wasn't
contained in resource_names_, and so it failed that check -- causing the
background image to be placed weirdly.  This fixes that hole -- all
themeable_images are now mapped to their names in resource_names_, and so can be
tested for customhood.

Expand Messages | Collapse Messages