Fix problem of white box appearing in themes without an NTP background image....

chrome/browser/browser_theme_provider.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browser_theme_provider.h"
 
 #include "base/file_util.h"
 #include "base/string_util.h"
 #include "base/gfx/png_decoder.h"
 #include "base/gfx/png_encoder.h"
@@ skipping 238 matching lines @@
     resource_names_[IDR_THEME_FRAME_INACTIVE] = "theme_frame_inactive";
     resource_names_[IDR_THEME_FRAME_OVERLAY] = "theme_frame_overlay";
     resource_names_[IDR_THEME_FRAME_OVERLAY_INACTIVE] =
         "theme_frame_overlay_inactive";
     resource_names_[IDR_THEME_FRAME_INCOGNITO] = "theme_frame_incognito";
     resource_names_[IDR_THEME_FRAME_INCOGNITO_INACTIVE] =
         "theme_frame_incognito_inactive";
     resource_names_[IDR_THEME_TAB_BACKGROUND] = "theme_tab_background";
     resource_names_[IDR_THEME_TAB_BACKGROUND_INCOGNITO] =
         "theme_tab_background_incognito";
+    resource_names_[IDR_THEME_TOOLBAR] = "theme_toolbar";

[Glen Murphy, 2009/09/10 04:45:36]

Are these meant to be part of this CL?

[Miranda Callahan, 2009/09/10 15:28:43]

Yes and no; when I moved the code in DOMUIThemeSource, it exposed a problem with
my change to HasCustomImage -- namely, that THEME_NTP_BACKGROUND wasn't
contained in resource_names_, and so it failed that check -- causing the
background image to be placed weirdly.  This fixes that hole -- all
themeable_images are now mapped to their names in resource_names_, and so can be
tested for customhood.

+    resource_names_[IDR_THEME_TAB_BACKGROUND_V] = "theme_tab_background_v";
+    resource_names_[IDR_THEME_NTP_BACKGROUND] = "theme_ntp_background";
+    resource_names_[IDR_THEME_BUTTON_BACKGROUND] = "theme_button_background";
+    resource_names_[IDR_THEME_NTP_ATTRIBUTION] = "theme_ntp_attribution";
+    resource_names_[IDR_THEME_WINDOW_CONTROL_BACKGROUND] =
+        "theme_window_control_background";
   }
 }
 
 BrowserThemeProvider::~BrowserThemeProvider() {
   ClearCaches();
 }
 
 void BrowserThemeProvider::Init(Profile* profile) {
   DCHECK(CalledOnValidThread());
   profile_ = profile;
@@ skipping 970 matching lines @@
   }
   image_cache_.clear();
   images_disk_cache_.clear();
 }
 
 #if defined(TOOLKIT_VIEWS)
 void BrowserThemeProvider::FreePlatformCaches() {
   // Views (Skia) has no platform image cache to clear.
 }
 #endif