chrome/browser/autocomplete/autocomplete_edit_view_mac.mm - Issue 194056: Fix text and selection's save/restore issue of omnibox when displaying tempor...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

Issue 194056: Fix text and selection's save/restore issue of omnibox when displaying tempor... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 11 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autocomplete/autocomplete_edit.cc ('K') | « chrome/browser/autocomplete/autocomplete_edit_view_mac.h ('k') | chrome/browser/autocomplete/autocomplete_popup_model.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

===================================================================

--- chrome/browser/autocomplete/autocomplete_edit_view_mac.mm (revision 25735)

+++ chrome/browser/autocomplete/autocomplete_edit_view_mac.mm (working copy)

@@ -451,10 +451,8 @@

// TODO(shess): I believe this is for when the user arrows around

// the popup, will be restored if they hit escape. Figure out if

// that is for certain it.

- if (save_original_selection) {

+ if (save_original_selection)

saved_temporary_selection_ = GetSelectedRange();

- saved_temporary_text_ = GetText();

- }

SetWindowTextAndCaretPos(display_text, display_text.size());

controller_->OnChanged();

@@ -478,8 +476,7 @@

}

void AutocompleteEditViewMac::OnRevertTemporaryText() {

- SetTextAndSelectedRange(saved_temporary_text_, saved_temporary_selection_);

- saved_temporary_text_.clear();

+ SetSelectedRange(saved_temporary_selection_);

}

bool AutocompleteEditViewMac::IsFirstResponder() const {