Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: chrome/browser/autocomplete/autocomplete_edit.cc

Issue 194056: Fix text and selection's save/restore issue of omnibox when displaying tempor... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/autocomplete/autocomplete_edit_view_gtk.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autocomplete/autocomplete_edit.cc
===================================================================
--- chrome/browser/autocomplete/autocomplete_edit.cc (revision 25735)
+++ chrome/browser/autocomplete/autocomplete_edit.cc (working copy)
@@ -456,6 +456,10 @@
return;
}
+ // TODO(suzhe): It shouldn't affect inline autocomplete text at all.
Peter Kasting 2009/09/10 19:30:27 Nit: The substance here is fine, the grammar is a
+ // Instead, the edit should deal with it separately in Observe(), and
+ // save and restore it properly around setting/resetting temporary text.
+ //
// Handle changes to inline autocomplete text. Don't make changes if the user
// is showing temporary text. Making display changes would be obviously
// wrong; making changes to the inline_autocomplete_text_ itself turns out to
« no previous file with comments | « no previous file | chrome/browser/autocomplete/autocomplete_edit_view_gtk.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698