Issue 194054: Reduce the chunk size from 64 pages to 16 pages per chunk....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 194054: Reduce the chunk size from 64 pages to 16 pages per chunk.... (Closed)

Created:
11 years, 3 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Reduce the chunk size from 64 pages to 16 pages per chunk. This reduces the initial V8 memory usage by roughly 2MB. Committed: http://code.google.com/p/v8/source/detail?r=2856

Patch Set 1 #

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -6 lines)			Patch
	M	src/spaces.h	View		1 chunk	+2 lines, -6 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

LGTM, but doesn't it only reduce it by 5 * (64 - 16) * 8KB ...

11 years, 3 months ago (2009-09-09 10:52:55 UTC) #2

Mads Ager (chromium)

11 years, 3 months ago (2009-09-09 10:55:40 UTC) #3

On 2009/09/09 10:52:55, Kasper Lund wrote:
> LGTM, but doesn't it only reduce it by 5 * (64 - 16) * 8KB = 1.92MB?

Yes.  Description updated.

> http://codereview.chromium.org/194054/diff/1/2
> File src/spaces.h (right):
> 
> http://codereview.chromium.org/194054/diff/1/2#newcode449
> Line 449: // 8 * 1024 * 16 * 8K = 1G bytes.
> Why not 8K * 8K * 16?

Done.

Expand Messages | Collapse Messages