src/spaces.h - Issue 194054: Reduce the chunk size from 64 pages to 16 pages per chunk....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/spaces.h

Issue 194054: Reduce the chunk size from 64 pages to 16 pages per chunk.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 11 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/spaces.h

===================================================================

--- src/spaces.h (revision 2853)

+++ src/spaces.h (working copy)

@@ -445,13 +445,9 @@

// Due to encoding limitation, we can only have 8K chunks.

static const int kMaxNofChunks = 1 << Page::kPageSizeBits;

- // If a chunk has at least 32 pages, the maximum heap size is about

- // 8 * 1024 * 32 * 8K = 2G bytes.

-#if defined(ANDROID)

+ // If a chunk has at least 16 pages, the maximum heap size is about

+ // 8 * 1024 * 16 * 8K = 1G bytes.

Kasper Lund 2009/09/09 10:52:55 Why not 8K * 8K * 16?

static const int kPagesPerChunk = 16;

-#else

- static const int kPagesPerChunk = 64;

-#endif

static const int kChunkSize = kPagesPerChunk * Page::kPageSize;

private:

« no previous file with comments | « no previous file | no next file » | no next file with comments »