Issue 194042: [chromium-reviews] Disable extensions shelf toggle {Ctrl + Alt + B} for extensions appearing on ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 194042: [chromium-reviews] Disable extensions shelf toggle {Ctrl + Alt + B} for extensions appearing on ... (Closed)

Created:
11 years, 3 months ago by sidchat (Google)

Modified:
9 years, 7 months ago

Reviewers:
Finnur

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Disable extensions shelf toggle {Ctrl + Alt + B} for extensions appearing on top. BUG=20936 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25752

Patch Set 1 #

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	chrome/browser/browser.cc	View		1 chunk	+4 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Finnur

This is fine, although it is not what the bug is about. Maybe the bug ...

11 years, 3 months ago (2009-09-08 18:28:47 UTC) #2

Finnur

(my last message is an LG with nits, in case you were wondering) :) On ...

11 years, 3 months ago (2009-09-08 18:29:11 UTC) #3

Finnur

11 years, 3 months ago (2009-09-08 18:30:10 UTC) #4

Ah, I see you already updated the bug. Sorry for the confusion.


On 2009/09/08 18:29:11, Finnur wrote:
> (my last message is an LG with nits, in case you were wondering) :)
> 
> On 2009/09/08 18:28:47, Finnur wrote:
> > This is fine, although it is not what the bug is about. Maybe the bug should
> be
> > updated to reflect what you want to do here.
> > 
> > http://codereview.chromium.org/194042/diff/1/2
> > File chrome/browser/browser.cc (right):
> > 
> > http://codereview.chromium.org/194042/diff/1/2#newcode1167
> > Line 1167: kShowExtensionsOnTop)) {
> > I wouldn't split up switches:: and kShowExtensionsOnTop. It is better to put
> the
> > switches prefix on the next line.

Expand Messages | Collapse Messages