[chromium-reviews] Disable extensions shelf toggle {Ctrl + Alt + B} for extensions appearing on ...

chrome/browser/browser.cc

 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browser.h"
 
 #include "app/animation.h"
 #include "app/l10n_util.h"
 #include "base/command_line.h"
 #include "base/idle_timer.h"
@@ skipping 1145 matching lines @@
   UserMetrics::RecordAction(L"ReportBug", profile_);
   window_->ShowReportBugDialog();
 }
 
 void Browser::ToggleBookmarkBar() {
   UserMetrics::RecordAction(L"ShowBookmarksBar", profile_);
   window_->ToggleBookmarkBar();
 }
 
 void Browser::ToggleExtensionShelf() {
+  if (CommandLine::ForCurrentProcess()->HasSwitch(switches::
+      kShowExtensionsOnTop)) {

[Finnur, 2009/09/08 18:28:51]

I wouldn't split up switches:: and kShowExtensionsOnTop. It is better to put the
switches prefix on the next line.

+    return;
+  }
   UserMetrics::RecordAction(L"ToggleExtensionShelf", profile_);
   window_->ToggleExtensionShelf();
 }
 
 void Browser::OpenBookmarkManager() {
   UserMetrics::RecordAction(L"ShowBookmarkManager", profile_);
   window_->ShowBookmarkManager();
 }
 
 void Browser::ShowAppMenu() {
@@ skipping 1706 matching lines @@
 ///////////////////////////////////////////////////////////////////////////////
 // BrowserToolbarModel (private):
 
 NavigationController* Browser::BrowserToolbarModel::GetNavigationController() {
   // This |current_tab| can be NULL during the initialization of the
   // toolbar during window creation (i.e. before any tabs have been added
   // to the window).
   TabContents* current_tab = browser_->GetSelectedTabContents();
   return current_tab ? &current_tab->controller() : NULL;
 }