Fix hottracking on button views...

Fix hottracking on button views.The hottracking on the toolbar was broken, the expected behavoir is when focus is set to the toolbar (by hitting SHIFT+ALT+T) and toolbar buttons are traversed by right/left arrow keys, a bevel should appear on the button (HOT Image).

This patch fixes the initial hottracking issue where the first item is not hottracked.

BUG=10942
TEST=ALT+SHIFT+T and traverse with arrow keys, observe hot tracking.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27145

[Mohamed Mansour, 2009-09-07 03:24:35]

Please review, Ben and Scott are familiar with the Views code. Simple change
that allows hottracking for buttons.

[Peter Kasting, 2009-09-07 04:33:52]

http://codereview.chromium.org/194037/diff/1/2
File views/controls/button/custom_button.cc (right):

http://codereview.chromium.org/194037/diff/1/2#newcode223
Line 223: if (flag && state_ != BS_DISABLED) {
Drive-by: This function would be cleaner as:

if (state_ != BS_DISABLED)
  SetState(flag ? BS_HOT : BS_NORMAL);

[Mohamed Mansour, 2009-09-07 05:06:37]

http://codereview.chromium.org/194037/diff/1/2
File views/controls/button/custom_button.cc (right):

http://codereview.chromium.org/194037/diff/1/2#newcode223
Line 223: if (flag && state_ != BS_DISABLED) {
On 2009/09/07 04:33:52, Peter Kasting wrote:
> Drive-by: This function would be cleaner as:
> 
> if (state_ != BS_DISABLED)
>   SetState(flag ? BS_HOT : BS_NORMAL);

Done. Its way cleaner thanks!

[sky, 2009-09-08 15:57:05]

http://codereview.chromium.org/194037/diff/2002/2003
File views/controls/button/custom_button.cc (right):

http://codereview.chromium.org/194037/diff/2002/2003#newcode222
Line 222: void CustomButton::SetHotTracked(bool flag) {
The getter and setter for state is public. Any reason we need a cover method
like this? Is it going to be used alot?

[tfarina (gmail-do not use), 2009-09-08 16:20:14]

Also there is a old CL that does this, but was never committed.
http://codereview.chromium.org/100333/show

[Mohamed Mansour, 2009-09-09 01:16:16]

On 2009/09/08 16:20:14, tfarina wrote:
> Also there is a old CL that does this, but was never committed.
> http://codereview.chromium.org/100333/show

Ah didn't see that, anyways, this patch fixes other problems as well such not
hottracking the initial item.

sky, I agree as well, klink could answer that I guess. Currently, its only used
within the toolbar_view.

[Jonas Klink (Google), 2009-09-22 02:35:55]

Sorry if there was a hold-up on me on this one, just saw that this CL still
seems to be pending. I'm fine with doing without the cover method.

On Tue, Sep 8, 2009 at 6:16 PM, <mhm@chromium.org> wrote:

> On 2009/09/08 16:20:14, tfarina wrote:
>
>> Also there is a old CL that does this, but was never committed.
>> http://codereview.chromium.org/100333/show
>>
>
> Ah didn't see that, anyways, this patch fixes other problems as well
> such not hottracking the initial item.
>
> sky, I agree as well, klink could answer that I guess. Currently, its
> only used within the toolbar_view.
>
>
> http://codereview.chromium.org/194037
>

[Mohamed Mansour, 2009-09-22 02:56:47]

On 2009/09/22 02:35:55, Jonas Klink (Google) wrote:
> Sorry if there was a hold-up on me on this one, just saw that this CL still
> seems to be pending. I'm fine with doing without the cover method.

The "View" class has SetHotTracked, IsHotTracked abstract methods. So what do
you want to be done here?

[sky, 2009-09-22 15:53:51]

My mistake. LGTM.