Issue 194036: Removes a piece of comment that no longer applies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 194036: Removes a piece of comment that no longer applies. (Closed)

Created:
11 years, 3 months ago by tfarina (gmail-do not use)

Modified:
9 years, 7 months ago

Reviewers:
Erik does not do reviews

CC:
chromium-reviews_googlegroups.com, John Grabowski, brettw, pam+watch_chromium.org

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Removes a piece of comment that no longer applies. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25982

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	base/file_util_posix.cc	View		1 chunk	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tfarina (gmail-do not use)

On 2009/09/08 15:59:09, Erik Kay wrote: > LGTM Can you land it to me Erik?

11 years, 3 months ago (2009-09-11 00:18:05 UTC) #3

Erik does not do reviews

11 years, 3 months ago (2009-09-11 00:37:50 UTC) #4

Sure.  I'll try to land it tomorrow (and the other one).

On Thu, Sep 10, 2009 at 5:18 PM,  <thiago.farina@gmail.com> wrote:
> On 2009/09/08 15:59:09, Erik Kay wrote:
>>
>> LGTM
>
> Can you land it to me Erik?
>
>
> http://codereview.chromium.org/194036
>

Expand Messages | Collapse Messages