Issue 1940: Replaced calls to functions that msvc consider deprecated. Used...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1940: Replaced calls to functions that msvc consider deprecated. Used... (Closed)

Created:
12 years, 3 months ago by plesner

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Replaced calls to functions that msvc consider deprecated. Used Vector<...> in more places to be sure that buffers have a length associated with them. Committed: http://code.google.com/p/v8/source/detail?r=283

Patch Set 1 #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+257 lines, -197 lines)			Patch
M	SConstruct	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	src/counters.h	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	src/counters.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/disasm.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/disasm-ia32.cc	View	8 chunks	+14 lines, -28 lines	0 comments	Download
M	src/disassembler.cc	View	6 chunks	+10 lines, -12 lines	0 comments	Download
M	src/execution.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/flags.cc	View	2 chunks	+19 lines, -19 lines	0 comments	Download
M	src/log.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/platform.h	View	2 chunks	+8 lines, -3 lines	0 comments	Download
M	src/platform-linux.cc	View	4 chunks	+31 lines, -7 lines	0 comments	Download
M	src/platform-win32.cc	View	7 chunks	+56 lines, -23 lines	0 comments	Download
M	src/prettyprinter.cc	View	3 chunks	+9 lines, -8 lines	0 comments	Download
M	src/serialize.cc	View	2 chunks	+7 lines, -6 lines	0 comments	Download
M	src/string-stream.cc	View	2 chunks	+4 lines, -13 lines	0 comments	Download
M	src/top.cc	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	src/utils.h	View	7 chunks	+27 lines, -5 lines	0 comments	Download
M	src/utils.cc	View	6 chunks	+11 lines, -13 lines	0 comments	Download
M	test/cctest/cctest.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	test/cctest/test-compiler.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	test/cctest/test-debug.cc	View	3 chunks	+26 lines, -23 lines	0 comments	Download
M	test/cctest/test-utils.cc	View	1 chunk	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

12 years, 3 months ago (2008-09-11 14:32:11 UTC) #2

LGTM.

platform-macos.cc seems to be missing though.

Expand Messages | Collapse Messages