test/cctest/cctest.cc - Issue 1940: Replaced calls to functions that msvc consider deprecated. Used...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/cctest.cc

Issue 1940: Replaced calls to functions that msvc consider deprecated. Used... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 12 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/cctest.cc

===================================================================

--- test/cctest/cctest.cc (revision 280)

+++ test/cctest/cctest.cc (working copy)

@@ -44,9 +44,9 @@

basename = strrchr(const_cast<char *>(file), '\\');

}

if (!basename) {

- basename = strdup(file);

+ basename = v8::internal::OS::StrDup(file);

} else {

- basename = strdup(basename + 1);

+ basename = v8::internal::OS::StrDup(basename + 1);

}

// Drop the extension, if there is one.

char *extension = strrchr(basename, '.');

@@ -77,7 +77,7 @@

print_run_count = false;

} else {

- char* arg_copy = strdup(arg);

+ char* arg_copy = v8::internal::OS::StrDup(arg);

char* testname = strchr(arg_copy, '/');

if (testname) {

// Split the string in two by nulling the slash and then run

« no previous file with comments | « src/utils.cc ('k') | test/cctest/test-compiler.cc » ('j') | no next file with comments »