Issue 193047: Fix to use FilePath version of PathService::Get....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 193047: Fix to use FilePath version of PathService::Get.... (Closed)

Created:
11 years, 3 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
tfarina (gmail-do not use)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Fix to use FilePath version of PathService::Get. BUG=None TEST=None Original Review URL: http://codereview.chromium.org/174189 Patch from Thiago Farina <thiago.farina@gmail.com>;. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25778

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+70 lines, -74 lines)			Patch
M	app/resource_bundle_win.cc	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	base/file_version_info.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/file_version_info_unittest.cc	View	5 chunks	+12 lines, -13 lines	0 comments	Download
M	chrome/browser/blocked_popup_container_interactive_uitest.cc	View	7 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/dom_ui/chrome_url_data_manager.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/importer/safari_importer_unittest.mm	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/process_singleton_win.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/rlz/rlz.cc	View	2 chunks	+5 lines, -6 lines	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_database_unittest.cc	View	5 chunks	+7 lines, -9 lines	0 comments	Download
M	chrome/browser/search_engines/template_url_parser_unittest.cc	View	9 chunks	+13 lines, -13 lines	0 comments	Download
M	chrome/common/json_value_serializer_perftest.cc	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	chrome/test/ui/omnibox_uitest.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	net/url_request/url_request_unittest.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/glue/unittest_test_server.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 1 (0 generated)

This is http://codereview.chromium.org/184006