Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 174189: Remove uses of deprecated version of FileUtil::PathExists() in the installer.... (Closed)

Created:
11 years, 4 months ago by tfarina (gmail-do not use)
Modified:
9 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews_googlegroups.com, kuchhal
Visibility:
Public.

Description

Remove uses of deprecated version of FileUtil::PathExists() in the installer. BUG=None TEST=run installer_util_unittests.exe Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24320

Patch Set 1 #

Total comments: 4

Patch Set 2 : wstring_exe_full_path removed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+515 lines, -469 lines) Patch
M chrome/installer/util/copy_tree_work_item_unittest.cc View 1 22 chunks +187 lines, -169 lines 0 comments Download
M chrome/installer/util/create_dir_work_item_unittest.cc View 1 4 chunks +31 lines, -31 lines 0 comments Download
M chrome/installer/util/create_reg_key_work_item_unittest.cc View 1 2 chunks +64 lines, -49 lines 0 comments Download
M chrome/installer/util/delete_tree_work_item_unittest.cc View 1 3 chunks +57 lines, -53 lines 0 comments Download
M chrome/installer/util/helper_unittest.cc View 1 2 chunks +63 lines, -63 lines 0 comments Download
M chrome/installer/util/move_tree_work_item_unittest.cc View 1 6 chunks +103 lines, -94 lines 0 comments Download
M chrome/installer/util/work_item_list_unittest.cc View 1 2 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina (gmail-do not use)
11 years, 4 months ago (2009-08-20 22:34:47 UTC) #1
tfarina (gmail-do not use)
Ping
11 years, 4 months ago (2009-08-25 00:23:04 UTC) #2
Lei Zhang
On 2009/08/25 00:23:04, tfarina wrote: > Ping Sorry, I haven't gotten around to it yet. ...
11 years, 4 months ago (2009-08-25 00:31:31 UTC) #3
Lei Zhang
Look mostly good. http://codereview.chromium.org/174189/diff/1/2 File chrome/installer/util/copy_tree_work_item_unittest.cc (right): http://codereview.chromium.org/174189/diff/1/2#newcode350 Line 350: << exe_full_path.value() << " to ...
11 years, 4 months ago (2009-08-25 00:56:31 UTC) #4
tfarina (gmail-do not use)
http://codereview.chromium.org/174189/diff/1/5 File chrome/installer/util/delete_tree_work_item_unittest.cc (right): http://codereview.chromium.org/174189/diff/1/5#newcode189 Line 189: FilePath exe_full_path(wstring_exe_full_path); On 2009/08/25 00:56:31, Lei Zhang wrote: ...
11 years, 4 months ago (2009-08-25 01:27:37 UTC) #5
Lei Zhang
11 years, 4 months ago (2009-08-25 18:42:41 UTC) #6
LGTM

I will commit on your behalf later today unless you say otherwise.

Powered by Google App Engine
This is Rietveld 408576698