Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 193027: Chrome UI language menu fix and add Hawaiian to the A-L list. (Closed)

Created:
11 years, 3 months ago by jungshik at Google
Modified:
9 years, 7 months ago
Reviewers:
tony
CC:
chromium-reviews_googlegroups.com, Mark Larson, laforge, sidchat (Google)
Visibility:
Public.

Description

UI language list fix. 30+ minimally populated locales were added to our ICU data. As a result, GetAvailableLocale() used whenconstructing the UI language menu in Chrome list languages Chrome is not localized to. 1. Add IsPartiallyPopulatedLocale() to l10n_util (anonymous namespace) and skip those locales when constructing the locale list. 2. Add 'Hawaiian', 'Oromo' and 'Hausa' to the Accept-Language list. I'll add other languages to the trunk later. BUG=21119 (http://crbug.com/21119), 19329 ( http://crbug.com/19329 ) TEST=1. Launch Chrome and go to Options | "Advanced" | Languages & Fonts menu | Languages tab | Google Chrome language. The list of languages to choose from should contain only languages Chrome is localized to (40 + 1 + 8) and should not contain languages like Hawaian, Belarusian. 2. Accept-Language list should contain 3 new languages added (Hawaiian, Oromo and Hausa) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26230

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -11 lines) Patch
M app/l10n_util.cc View 1 2 5 chunks +36 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jungshik at Google
I forgot to press 'the publish button' for this while the branch CL was reviewed ...
11 years, 3 months ago (2009-09-14 23:02:26 UTC) #1
tony
11 years, 3 months ago (2009-09-14 23:11:13 UTC) #2
I see, LGTM

Powered by Google App Engine
This is Rietveld 408576698