Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 192029: UI language list fix for the branch. (the trunk patch - essentially identical... (Closed)

Created:
11 years, 3 months ago by jungshik at Google
Modified:
9 years, 7 months ago
Reviewers:
tony
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google), Mark Larson, laforge, sidchat (Google)
Visibility:
Public.

Description

UI language list fix for the branch. (the trunk patch ( http://codereview.chromium.org/193027/) - essentially identical except for [1] below) 30+ minimally populated locales were added to our ICU data. As a result, GetAvailableLocale() used whenconstructing the UI language menu in Chrome list languages Chrome is not localized to. 1. Add IsPartiallyPopulatedLocale() to l10n_util (anonymous namespace) and skip those locales when constructing the locale list. 2. Add 'Hawaiian' to the Accept-Language list. I'll add other languages to the trunk later. [1] The accept-language list moved from chrome/browser/...page_view.cc to l10n_util.cc recently. For the branch, we have to change that file. In addition, what's refactored to IsLocaleNameTranslated() in the trunk patch is not refactored to minimize the code change in the last-minute branch patch. BUG=21119 (http://crbug.com/21119), 19329 ( http://crbug.com/19329 ) TEST=Launch Chrome and go to Options | "Advanced" | Languages & Fonts menu | Languages tab | Google Chrome language. The list of languages to choose from should contain only languages Chrome is localized to (40 + 1 + 8) and should not contain languages like Hawaian, Belarusian. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25535

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M app/l10n_util.cc View 2 chunks +29 lines, -0 lines 0 comments Download
M chrome/browser/views/options/languages_page_view.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jungshik at Google
This is to fix a regression in the branch.
11 years, 3 months ago (2009-09-04 21:51:53 UTC) #1
tony
11 years, 3 months ago (2009-09-04 22:02:29 UTC) #2
I see.  This LGTM.

Powered by Google App Engine
This is Rietveld 408576698