Use "GURL::possibly_invalid_spec()" rather than "GURL::spec()", in case the G...

Use "GURL::possibly_invalid_spec()" rather than "GURL::spec()", in case the GURL that was passed to URLRequest(const GURL&) is invalid.

BUG=http://crbug.com/21423


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25903

[Peter Kasting, 2009-09-09 23:21:06]

(I added brettw because I don't know if this violates some contract)

[brettw, 2009-09-09 23:53:22]

When is this used? URLRequests for invalid URLs should be failing. Should those
be getting filtered out before this? If this is really a "tracker" it's
certainly reasonable for them to be invalid and we should be handling it.

[eroman, 2009-09-10 00:02:15]

Right, it is expected that we need to handle invalid GURLs here.

URLRequest may have been constructed with an invalid GURL.

This is OK in the normal flow, since when you call URLRequest::Start(), it calls
URLRequestJobManager::CreateJob() which checks for invalid URLs and throws
net::ERR_INVALID_URL if so.

Now with the URLRequest::InstanceTracker stuff (recent addition), it is
extracting the GURL that URLRequest was constructed with, which may or may not
be valid. Hence it must assume the spec can be invalid.

[brettw, 2009-09-10 00:05:01]

Then LGTM

[willchan no longer on Chromium, 2009-09-10 18:53:40]

lgtm