Use "GURL::possibly_invalid_spec()" rather than "GURL::spec()", in case the G...

net/url_request/url_request_unittest.cc

 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request_unittest.h"
 
 #include "build/build_config.h"
 
 #if defined(OS_WIN)
 #include <windows.h>
@@ skipping 251 matching lines @@
   ASSERT_EQ(3u, recent_reqs.size());
   EXPECT_EQ(GURL("http://req3"), recent_reqs[0].original_url);
   EXPECT_EQ(GURL("http://req2"), recent_reqs[1].original_url);
   EXPECT_EQ(GURL("http://req1"), recent_reqs[2].original_url);
 }
 
 // Test the instance tracking functionality of URLRequest.
 TEST_F(URLRequestTest, TrackingGraveyardBounded) {
   URLRequest::InstanceTracker::Get()->ClearRecentlyDeceased();
   EXPECT_EQ(0u, URLRequest::InstanceTracker::Get()->GetLiveRequests().size());
-  EXPECT_EQ(0u, URLRequest::InstanceTracker::Get()->GetLiveRequests().size());
+  EXPECT_EQ(0u,
+            URLRequest::InstanceTracker::Get()->GetRecentlyDeceased().size());
 
   const size_t kMaxGraveyardSize =
       URLRequest::InstanceTracker::kMaxGraveyardSize;
   const size_t kMaxURLLen = URLRequest::InstanceTracker::kMaxGraveyardURLSize;
 
   // Add twice as many requests as will fit in the graveyard.
   for (size_t i = 0; i < kMaxGraveyardSize * 2; ++i)
     URLRequest req(GURL(StringPrintf("http://req%d", i).c_str()), NULL);
 
   // Check that only the last |kMaxGraveyardSize| requests are in-memory.
@@ skipping 22 matching lines @@
   }
   ASSERT_EQ(1u,
             URLRequest::InstanceTracker::Get()->GetRecentlyDeceased().size());
   // The +1 is because GURL canonicalizes with a trailing '/' ... maybe
   // we should just save the std::string rather than the GURL.
   EXPECT_EQ(kMaxURLLen + 1,
             URLRequest::InstanceTracker::Get()->GetRecentlyDeceased()[0]
                 .original_url.spec().size());
 }
 
+// Test the instance tracking functionality of URLRequest does not
+// fail if the URL was invalid. http://crbug.com/21423.
+TEST_F(URLRequestTest, TrackingInvalidURL) {
+  URLRequest::InstanceTracker::Get()->ClearRecentlyDeceased();
+  EXPECT_EQ(0u, URLRequest::InstanceTracker::Get()->GetLiveRequests().size());
+  EXPECT_EQ(0u,
+            URLRequest::InstanceTracker::Get()->GetRecentlyDeceased().size());
+
+  {
+    GURL invalid_url("xabc");
+    EXPECT_FALSE(invalid_url.is_valid());
+    URLRequest req(invalid_url, NULL);
+  }
+
+  // Check that the invalid URL made it into graveyard.
+  URLRequest::InstanceTracker::RecentRequestInfoList recent_reqs =
+      URLRequest::InstanceTracker::Get()->GetRecentlyDeceased();
+
+  ASSERT_EQ(1u, recent_reqs.size());
+  EXPECT_FALSE(recent_reqs[0].original_url.is_valid());
+}
+
 TEST_F(URLRequestTest, QuitTest) {
   // Don't use shared server here because we order it to quit.
   // It would impact other tests.
   scoped_refptr<HTTPTestServer> server =
       HTTPTestServer::CreateServer(L"", NULL);
   ASSERT_TRUE(NULL != server.get());
   server->SendQuit();
   EXPECT_TRUE(server->WaitToFinish(20000));
 }
 
@@ skipping 1768 matching lines @@
 
     int64 file_size = 0;
     file_util::GetFileSize(app_path, &file_size);
 
     EXPECT_FALSE(r.is_pending());
     EXPECT_EQ(1, d.response_started_count());
     EXPECT_FALSE(d.received_data_before_response());
     EXPECT_EQ(d.bytes_received(), static_cast<int>(file_size));
   }
 }