Issue 192052: Rolling in latest gyp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 192052: Rolling in latest gyp. (Closed)

Created:
11 years, 3 months ago by bradn

Modified:
9 years, 7 months ago

Reviewers:
fta, sgk

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Description

Rolling in latest gyp. BUG=None TEST=None TBR=sgk Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25742

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

fta

On 2009/09/09 12:06:52, sgk wrote: > lgtm (should be a virtual no-op since r640 reverted ...

11 years, 3 months ago (2009-09-14 13:01:53 UTC) #3

sgk

11 years, 3 months ago (2009-09-14 13:26:59 UTC) #4

Details, please.  Would like to fix ASAP.
Also:  point me to your build steps, preferably the tip of whatever SVN (or
other SCM repository) you use.  I'd like to try to set up a buildbot canary
that replicates your steps so we can start catching these problems before
rolling.

        --SK

On Mon, Sep 14, 2009 at 6:01 AM, <fta@sofaraway.org> wrote:

> On 2009/09/09 12:06:52, sgk wrote:
>
>> lgtm (should be a virtual no-op since r640 reverted r639)
>>
>
> it's definitely not a no-op as my Ubuntu builds are broken since this
> landed.
>
>
> http://codereview.chromium.org/192052
>

Expand Messages | Collapse Messages