Don't log empty FTP LIST responses as unknown server type.

Don't log empty FTP LIST responses as unknown server type.

The histograms will be more accurate after this change.

TEST=none
BUG=20335
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25638

[wtc, 2009-09-08 18:10:02]

LGTM.

Please use BUG=20335 in the CL's description.

[eroman, 2009-09-08 22:20:14]

lgtm

http://codereview.chromium.org/192038/diff/1/2
File net/url_request/url_request_new_ftp_job.cc (right):

http://codereview.chromium.org/192038/diff/1/2#newcode289
Line 289: if (!list_state.parsed_one)
Style comment:

I recommend doing this at the callsite of LogFtpServerType:

if (state.parsed_one)
  LogFtpServerType(state);

And have LogFtpServerType() DCHECK that parsed_one is true.

Since otherwise it seems awkward to call LogFtpServerType() and have it do
nothing.

[wtc, 2009-09-09 01:14:50]

http://codereview.chromium.org/192038/diff/1/2
File net/url_request/url_request_new_ftp_job.cc (right):

http://codereview.chromium.org/192038/diff/1/2#newcode289
Line 289: if (!list_state.parsed_one)
I agree.  I also suggest that we change
LogFtpServerType to take state.lstyle as the argument,
which is all it neeeds.