Don't log empty FTP LIST responses as unknown server type.

net/url_request/url_request_new_ftp_job.cc

Index: net/url_request/url_request_new_ftp_job.cc
diff --git a/net/url_request/url_request_new_ftp_job.cc b/net/url_request/url_request_new_ftp_job.cc
index a6b5e9f803067e4052798bfd55f60de71950ec49..0083e23bedf933d39fd4f32febc21aafaf9caf79 100644
--- a/net/url_request/url_request_new_ftp_job.cc
+++ b/net/url_request/url_request_new_ftp_job.cc
@@ -284,6 +284,11 @@ int URLRequestNewFtpJob::ProcessFtpDir(net::IOBuffer *buf,
 }
 
 void URLRequestNewFtpJob::LogFtpServerType(const net::ListState& list_state) {
+  // We can't recognize server type based on empty directory listings. Don't log
+  // that as unknown, it's misleading.
+  if (!list_state.parsed_one)

[eroman, 2009/09/08 22:20:14]

Style comment:

I recommend doing this at the callsite of LogFtpServerType:

if (state.parsed_one)
  LogFtpServerType(state);

And have LogFtpServerType() DCHECK that parsed_one is true.

Since otherwise it seems awkward to call LogFtpServerType() and have it do
nothing.

[wtc, 2009/09/09 01:14:50]

I agree.  I also suggest that we change
LogFtpServerType to take state.lstyle as the argument,
which is all it neeeds.

+    return;
+
   switch (list_state.lstyle) {
     case 'E':
       net::UpdateFtpServerTypeHistograms(net::SERVER_EPLF);