Fix the debugger in the ARM simulator

Fix the debugger in the ARM simulator.

The debugger in the ARM simulator is now working again.

Added a help command and a command to print all registers. Made the printobject command print something in release builds.

Committed: http://code.google.com/p/v8/source/detail?r=2818

[Erik Corry, 2009-09-02 14:22:41]

LGTM

http://codereview.chromium.org/191004/diff/1/2
File src/arm/simulator-arm.cc (right):

http://codereview.chromium.org/191004/diff/1/2#newcode383
Line 383: PrintF("print <register>\n");
It would be nice to include si/stepi and c/cont as well as the short versions of
all these commands.

[Søren Thygesen Gjesse, 2009-09-02 14:47:19]

http://codereview.chromium.org/191004/diff/1/2
File src/arm/simulator-arm.cc (right):

http://codereview.chromium.org/191004/diff/1/2#newcode383
Line 383: PrintF("print <register>\n");
On 2009/09/02 14:22:44, Erik Corry wrote:
> It would be nice to include si/stepi and c/cont as well as the short versions
of
> all these commands.

Added missing commands and description and alias as well.

[iposva, 2009-09-04 05:30:24]

After the fact comments that should be addressed.

-Ivan

http://codereview.chromium.org/191004/diff/1/2
File src/arm/simulator-arm.cc (right):

http://codereview.chromium.org/191004/diff/1/2#newcode276
Line 276: for (int i = 0; i <= 15; i++) {
Please use named constants here.

http://codereview.chromium.org/191004/diff/1/2#newcode278
Line 278: if (i <= 10) {
and here.

http://codereview.chromium.org/191004/diff/1/2#newcode281
Line 281: PrintF("%s: 08x%x %d\n", reg_names[15 + 16 - i], value, value);
and here.

Better yet, abstract the register to name mapping from the disassembler into
constants_arm.h and constants_arm.cc and use it here and in the disassembler.

http://codereview.chromium.org/191004/diff/1/2#newcode301
Line 301: USE(obj);
This USE can be dropped now, that obj is used in DEBUG and non-DEBUG builds.

[Søren Thygesen Gjesse, 2009-09-07 13:15:53]

On 2009/09/04 05:30:24, iposva wrote:
> After the fact comments that should be addressed.
> 
> -Ivan
> 
> http://codereview.chromium.org/191004/diff/1/2
> File src/arm/simulator-arm.cc (right):
> 
> http://codereview.chromium.org/191004/diff/1/2#newcode276
> Line 276: for (int i = 0; i <= 15; i++) {
> Please use named constants here.
> 
> http://codereview.chromium.org/191004/diff/1/2#newcode278
> Line 278: if (i <= 10) {
> and here.
> 
> http://codereview.chromium.org/191004/diff/1/2#newcode281
> Line 281: PrintF("%s: 08x%x %d\n", reg_names[15 + 16 - i], value, value);
> and here.
> 
> Better yet, abstract the register to name mapping from the disassembler into
> constants_arm.h and constants_arm.cc and use it here and in the disassembler.
> 
> http://codereview.chromium.org/191004/diff/1/2#newcode301
> Line 301: USE(obj);
> This USE can be dropped now, that obj is used in DEBUG and non-DEBUG builds.

These comments have been addressed in http://codereview.chromium.org/195024.