Issue 195024: Refactor the register to name mapping in the ARM simulator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 195024: Refactor the register to name mapping in the ARM simulator (Closed)

Created:
11 years, 3 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
iposva

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Refactor the register to name mapping in the ARM simulator. Committed: http://code.google.com/p/v8/source/detail?r=2847

Patch Set 2 : Added src/arm/constatns-arm.cc to Visual Studio project file #

Total comments: 4

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+142 lines, -64 lines)			Patch
M	src/SConscript	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/arm/constants-arm.h	View	2 chunks	+29 lines, -0 lines	2 comments	Download
A	src/arm/constants-arm.cc	View	1 chunk	+92 lines, -0 lines	0 comments	Download
M	src/arm/disasm-arm.cc	View	3 chunks	+2 lines, -17 lines	0 comments	Download
M	src/arm/simulator-arm.cc	View	4 chunks	+12 lines, -44 lines	2 comments	Download
M	tools/visual_studio/v8_base_arm.vcproj	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

iposva

LGTM with comments. -Ivan http://codereview.chromium.org/195024/diff/3002/3005 File src/arm/constants-arm.h (right): http://codereview.chromium.org/195024/diff/3002/3005#newcode282 Line 282: Please drop this extra ...

11 years, 3 months ago (2009-09-08 21:59:57 UTC) #2

Søren Thygesen Gjesse

11 years, 3 months ago (2009-09-09 07:01:12 UTC) #3

http://codereview.chromium.org/195024/diff/3002/3005
File src/arm/constants-arm.h (right):

http://codereview.chromium.org/195024/diff/3002/3005#newcode282
Line 282: 
On 2009/09/08 21:59:57, iposva wrote:
> Please drop this extra empty line.

Done.

http://codereview.chromium.org/195024/diff/3002/3006
File src/arm/simulator-arm.cc (right):

http://codereview.chromium.org/195024/diff/3002/3006#newcode73
Line 73: int32_t GetRegsiterValue(int regnum);
On 2009/09/08 21:59:57, iposva wrote:
> GetRegisterValue

Done.

Expand Messages | Collapse Messages

Issue 195024: Refactor the register to name mapping in the ARM simulator (Closed)

Description

Patch Set 1 #

Patch Set 2 : Added src/arm/constatns-arm.cc to Visual Studio project file #

Messages