Issue 19018: Fix a memory leak in release with ThreadCollisionWarner unit tests. Less than...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19018: Fix a memory leak in release with ThreadCollisionWarner unit tests. Less than... (Closed)

Created:
11 years, 11 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Fix a memory leak in release with ThreadCollisionWarner unit tests. Less than ideal #ifdef's. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8724

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -8 lines)			Patch
	M	base/thread_collision_warner_unittest.cc	View		4 chunks	+20 lines, -8 lines	0 comments	Download

Total messages: 3 (0 generated)

darin (slow to review)

wow, that is ugly. i thought about suggesting a helper function or a helper method, ...

11 years, 11 months ago (2009-01-27 17:27:38 UTC) #2

LGTM anyways