Fix a memory leak in release with ThreadCollisionWarner unit tests. Less than...

base/thread_collision_warner_unittest.cc

 // Copyright (c) 2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/compiler_specific.h"
 #include "base/lock.h"
 #include "base/platform_thread.h"
 #include "base/simple_thread.h"
 #include "base/thread_collision_warner.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 96 matching lines @@
     DFAKE_SCOPED_LOCK(warner);
     EXPECT_FALSE(local_reporter->fail_state());
   }  // Unpin section.
 }
 
 TEST(ThreadCollisionTest, MTBookCriticalSectionTest) {
   class NonThreadSafeQueue {
    public:
     explicit NonThreadSafeQueue(base::AsserterBase* asserter)
 #if !defined(NDEBUG)
-        : push_pop_(asserter)
+        : push_pop_(asserter) {
+#else
+    {
+      delete asserter;
 #endif
-    { }
+    }
 
     void push(int value) {
       DFAKE_SCOPED_LOCK_THREAD_LOCKED(push_pop_);
     }
 
     int pop() {
       DFAKE_SCOPED_LOCK_THREAD_LOCKED(push_pop_);
       return 0;
     }
 
@@ skipping 40 matching lines @@
 #endif
 }
 
 TEST(ThreadCollisionTest, MTScopedBookCriticalSectionTest) {
   // Queue with a 5 seconds push execution time, hopefuly the two used threads
   // in the test will enter the push at same time.
   class NonThreadSafeQueue {
    public:
     explicit NonThreadSafeQueue(base::AsserterBase* asserter)
 #if !defined(NDEBUG)
-        : push_pop_(asserter)
+        : push_pop_(asserter) {
+#else
+    {
+      delete asserter;
 #endif
-    { }
+    }
 
     void push(int value) {
       DFAKE_SCOPED_LOCK(push_pop_);
       PlatformThread::Sleep(5000);
     }
 
     int pop() {
       DFAKE_SCOPED_LOCK(push_pop_);
       return 0;
     }
@@ skipping 41 matching lines @@
 #endif
 }
 
 TEST(ThreadCollisionTest, MTSynchedScopedBookCriticalSectionTest) {
   // Queue with a 5 seconds push execution time, hopefuly the two used threads
   // in the test will enter the push at same time.
   class NonThreadSafeQueue {
    public:
     explicit NonThreadSafeQueue(base::AsserterBase* asserter)
 #if !defined(NDEBUG)
-        : push_pop_(asserter)
+        : push_pop_(asserter) {
+#else
+    {
+      delete asserter;
 #endif
-    { }
+    }
 
     void push(int value) {
       DFAKE_SCOPED_LOCK(push_pop_);
       PlatformThread::Sleep(5000);
     }
 
     int pop() {
       DFAKE_SCOPED_LOCK(push_pop_);
       return 0;
     }
@@ skipping 48 matching lines @@
   EXPECT_FALSE(local_reporter->fail_state());
 }
 
 TEST(ThreadCollisionTest, MTSynchedScopedRecursiveBookCriticalSectionTest) {
   // Queue with a 5 seconds push execution time, hopefuly the two used threads
   // in the test will enter the push at same time.
   class NonThreadSafeQueue {
    public:
     explicit NonThreadSafeQueue(base::AsserterBase* asserter)
 #if !defined(NDEBUG)
-        : push_pop_(asserter)
+        : push_pop_(asserter) {
+#else
+    {
+      delete asserter;
 #endif
-    { }
+    }
 
     void push(int) {
       DFAKE_SCOPED_RECURSIVE_LOCK(push_pop_);
       bar();
       PlatformThread::Sleep(5000);
     }
 
     int pop() {
       DFAKE_SCOPED_RECURSIVE_LOCK(push_pop_);
       return 0;
@@ skipping 49 matching lines @@
   base::DelegateSimpleThread thread_b(&queue_user_b, "queue_user_thread_b");
 
   thread_a.Start();
   thread_b.Start();
 
   thread_a.Join();
   thread_b.Join();
 
   EXPECT_FALSE(local_reporter->fail_state());
 }