Port some unit tests from chrome/browser/

Port some unit tests from chrome/browser/

Makes over 200 tests pass on Linux.

[Paweł Hajdan Jr., 2009-01-26 14:45:01]

This is quite big... please tell me if and how you'd like to have this divided
to more changesets.

On the other hand, most changes here are either of type 1 -> 1U, or
search/replace sqlite method names.

The best way to split (when needed) I think would be to sqlite changes and
non-sqlite changes.

[Dean McNamee, 2009-01-26 14:51:26]

I think the SQL changes deserve their own changelist (also with a more detailed
description of what the change does).  They should probably be review by someone
like brettw.

On 2009/01/26 14:45:01, Paweł Hajdan Jr. wrote:
> This is quite big... please tell me if and how you'd like to have this divided
> to more changesets.
> 
> On the other hand, most changes here are either of type 1 -> 1U, or
> search/replace sqlite method names.
> 
> The best way to split (when needed) I think would be to sqlite changes and
> non-sqlite changes.

[sgk, 2009-01-26 17:43:42]

SCons lgtm

[brettw, 2009-01-26 18:43:00]

I don't see HistoryIndexer being supported on any other platform. This is to
allow any of the indexers on Windows to read our data, and I don't see a need
for a analog on Linux.

[Paweł Hajdan Jr., 2009-01-30 20:33:54]

So this is the version after landing sqlite changes. Please review:

sgk: SCons (I made some minor changes to the previous patchset)
Mark: main part of the review, style, etc.
Dean: if you catch any issues
brettw: HistoryPublisher, and please also double-check my vcproj change

[brettw, 2009-01-30 20:39:41]

History publisher and vcproj LGTM

[Paweł Hajdan Jr., 2009-02-02 11:05:47]

sgk: ping (SCons)
Mark: ping (main review, style issues)
Dean: ping (if you catch any issues, please comment, otherwise just say "rubber
stamp" or something)

[Dean McNamee, 2009-02-02 11:14:35]

LGTM.  The changes seems straightforward enough, I don't think you need to wait
for more reviewers.

[Paweł Hajdan Jr., 2009-02-02 14:13:47]

On 2009/02/02 11:14:35, Dean McNamee wrote:
> LGTM.  The changes seems straightforward enough, I don't think you need to
wait
> for more reviewers.

Committed as http://src.chromium.org/viewvc/chrome?view=rev&revision=9041 .

[Mark Mentovai, 2009-02-02 16:33:56]

LGTM, I agree.