Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1481)

Unified Diff: chrome/browser/history/text_database_manager_unittest.cc

Issue 18758: Port some unit tests from chrome/browser/ (Closed)
Patch Set: port the tests Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/text_database_manager_unittest.cc
diff --git a/chrome/browser/history/text_database_manager_unittest.cc b/chrome/browser/history/text_database_manager_unittest.cc
index 8d9c10b4a51b3cc811a3d3283e8d2d75920d353f..14d2b904d70f3557f3e9eb1fbaf8eeed747148c9 100644
--- a/chrome/browser/history/text_database_manager_unittest.cc
+++ b/chrome/browser/history/text_database_manager_unittest.cc
@@ -49,7 +49,7 @@ class TextDatabaseManagerTest : public testing::Test {
void TearDown() {
file_util::Delete(dir_, true);
}
-
+
MessageLoop message_loop_;
// Directory containing the databases.
@@ -340,21 +340,21 @@ TEST_F(TextDatabaseManagerTest, PartialComplete) {
QueryOptions options;
std::vector<TextDatabase::Match> results;
manager.GetTextMatches(L"unique", options, &results, &first_time_searched);
- EXPECT_EQ(1, results.size());
+ EXPECT_EQ(1U, results.size());
manager.GetTextMatches(L"chocolate", options, &results, &first_time_searched);
- EXPECT_EQ(0, results.size());
+ EXPECT_EQ(0U, results.size());
// Now add the body, which should be queryable.
manager.AddPageContents(url, L"Very awesome body");
manager.GetTextMatches(L"awesome", options, &results, &first_time_searched);
- EXPECT_EQ(1, results.size());
+ EXPECT_EQ(1U, results.size());
// Adding the body will actually copy the title from the URL table rather
// than the previously indexed row (we made them not match above). This isn't
// necessarily what we want, but it's how it's implemented, and we don't want
// to regress it.
manager.GetTextMatches(L"chocolate", options, &results, &first_time_searched);
- EXPECT_EQ(1, results.size());
+ EXPECT_EQ(1U, results.size());
}
// Tests that changes get properly committed to disk.
« no previous file with comments | « chrome/browser/history/starred_url_database_unittest.cc ('k') | chrome/browser/history/url_database_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698