scripts/slave/recipe_modules/chromium_tests/steps.py - Issue 1871583004: Revert "Remove references to crash_service, which is no longer needed."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium_tests/steps.py

Issue 1871583004: Revert "Remove references to crash_service, which is no longer needed." (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipe_modules/chromium_tests/chromium_webkit.py ('k') | scripts/slave/recipes/chromium.expected/chromium_webkit_parent_revision_chromium.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/chromium_tests/steps.py

diff --git a/scripts/slave/recipe_modules/chromium_tests/steps.py b/scripts/slave/recipe_modules/chromium_tests/steps.py

index 58a0fe05541d442aced7a19dbf692e56be6f31d0..3be98861d36706757a31821ecc42ba51d2fc260f 100644

--- a/scripts/slave/recipe_modules/chromium_tests/steps.py

+++ b/scripts/slave/recipe_modules/chromium_tests/steps.py

@@ -1415,7 +1415,11 @@ class PrintPreviewTests(PythonBasedTest): # pylint: disable=W032

@staticmethod

def compile_targets(api):

- return ['browser_tests', 'blink_tests']

+ targets = ['browser_tests', 'blink_tests']

+ if api.platform.is_win:

+ targets.append('crash_service')

+ return targets

class BisectTest(Test): # pylint: disable=W0232

@@ -1814,7 +1818,7 @@ class WebViewCTSTest(Test):

@property

def name(self):

return 'WebView CTS'

@property

def uses_local_devices(self):

return True