Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: scripts/slave/recipe_modules/chromium_tests/chromium_webkit.py

Issue 1871583004: Revert "Remove references to crash_service, which is no longer needed." (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/chromium_tests/chromium_webkit.py
diff --git a/scripts/slave/recipe_modules/chromium_tests/chromium_webkit.py b/scripts/slave/recipe_modules/chromium_tests/chromium_webkit.py
index 03bf027014ddd9e6a6948450d14091f130b7c8ba..d5054245edd42b33e3f1a4e5f6b61134de35741e 100644
--- a/scripts/slave/recipe_modules/chromium_tests/chromium_webkit.py
+++ b/scripts/slave/recipe_modules/chromium_tests/chromium_webkit.py
@@ -24,6 +24,11 @@ SPEC['builders'].update({
'BUILD_CONFIG': 'Release',
'TARGET_BITS': 32,
},
+ 'compile_targets': [
+ # TODO(phajdan.jr): Find a way to automatically add crash_service
+ # to Windows builds (so that start_crash_service step works).
+ 'crash_service',
+ ],
'bot_type': 'builder',
'testing': {
'platform': 'win',
@@ -91,6 +96,10 @@ SPEC['builders'].update({
'compile_targets': [
# TODO(phajdan.jr): Shouldn't be needed once we have 64-bit testers.
'blink_tests',
+
+ # TODO(phajdan.jr): Find a way to automatically add crash_service
+ # to Windows builds (so that start_crash_service step works).
+ 'crash_service',
],
'bot_type': 'builder_tester',
'test_generators': [
@@ -112,6 +121,11 @@ SPEC['builders'].update({
'BUILD_CONFIG': 'Debug',
'TARGET_BITS': 32,
},
+ 'compile_targets': [
+ # TODO(phajdan.jr): Find a way to automatically add crash_service
+ # to Windows builds (so that start_crash_service step works).
+ 'crash_service',
+ ],
'bot_type': 'builder',
'testing': {
'platform': 'win',
@@ -155,6 +169,10 @@ SPEC['builders'].update({
'compile_targets': [
# TODO(phajdan.jr): Shouldn't be needed once we have 64-bit testers.
'blink_tests',
+
+ # TODO(phajdan.jr): Find a way to automatically add crash_service
+ # to Windows builds (so that start_crash_service step works).
+ 'crash_service',
],
'bot_type': 'builder_tester',
'test_generators': [
« no previous file with comments | « scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py ('k') | scripts/slave/recipe_modules/chromium_tests/steps.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698