GTK: Implement the bookmark bar chevron....

GTK: Implement the bookmark bar chevron.

I didn't use the native GtkToolbar version of this because, as usual, GTK doesn't give us enough flexibility to do what we want. But it wasn't too hard or super hacky to re-implement it.

The chromium version (and hence the Windows version) looks bad. This is not my fault. I don't know why it points right rather than down, when the menu pops down, not to the right. This is why I used a down arrow for the GTK version rather than matching with a right arrow.

BUG=15845
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25200

[Elliot Glaysher, 2009-09-02 01:19:39]

LGTM, one thing to think about?

http://codereview.chromium.org/187001/diff/2001/2003
File chrome/browser/gtk/bookmark_bar_gtk.cc (right):

http://codereview.chromium.org/187001/diff/2001/2003#newcode427
Line 427: gtk_arrow_new(GTK_ARROW_DOWN, GTK_SHADOW_NONE) :
This arrow, by default, is pretty big, no? You may want to take a look at how I
sized the comparable arrow in the download item. (IIRC, they're supposed to
match the font size.)

[Evan Stade, 2009-09-02 01:23:33]

no, it's not that big. Even without sizing it it's approximately the size of the
download item arrow. I think it's because the bookmark bar allocates it less
space (I presume the arrow draws itself the size of its allocation, except when
it has an explicit size request).

[Elliot Glaysher, 2009-09-02 01:24:55]

It tries to fill it's allocation. Anyway, if it's not a problem, LGTM.

On Tue, Sep 1, 2009 at 6:23 PM, <estade@chromium.org> wrote:
> no, it's not that big. Even without sizing it it's approximately the
> size of the download item arrow. I think it's because the bookmark bar
> allocates it less space (I presume the arrow draws itself the size of
> its allocation, except when it has an explicit size request).
>
> http://codereview.chromium.org/187001
>

[tony, 2009-09-02 20:24:09]

I think chevrons normally point to the right or left to indicate that there is
more in the toolbar, not the direction the menu will open.  Are there example
chevrons in GTK+ that do something different?

[Evan Stade, 2009-09-02 20:44:41]

On Wed, Sep 2, 2009 at 1:24 PM, <tony@chromium.org> wrote:
> I think chevrons normally point to the right or left to indicate that
> there is more in the toolbar, not the direction the menu will open. =A0Ar=
e
> there example chevrons in GTK+ that do something different?
>
> http://codereview.chromium.org/187001
>

here is the relevant line from gtktoolbar.c

priv->arrow =3D gtk_arrow_new (GTK_ARROW_DOWN, GTK_SHADOW_NONE);

[tony, 2009-09-03 00:02:33]

I see.  I like the Windows chevron better (it's not actually a chevron in
linux), but this seems to follow platform convention.  LGTM.

[Evan Stade, 2009-09-03 00:51:59]

On Wed, Sep 2, 2009 at 5:02 PM, <tony@chromium.org> wrote:
> I see. =A0I like the Windows chevron better (it's not actually a chevron
> in linux), but this seems to follow platform convention. =A0LGTM.
>
> http://codereview.chromium.org/187001
>

With some GTK themes, the arrow is a triangle. In other themes, it is
a chevron (although not a double chevron like the Windows one).

-- Evan Stade