Issue 18521: Keystone auto-update support for TestShell

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18521: Keystone auto-update support for TestShell (Closed)

Created:
11 years, 11 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
John Grabowski, jeremy

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Description

Keystone auto-update support for TestShell Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8574

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Total comments: 1

Patch Set 6 : '' #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1722 lines, -1 line)			Patch
A	build/mac/README.google	View		1 chunk	+5 lines, -0 lines	0 comments	Download
A	build/mac/pkg-dmg	View		1 chunk	+1520 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/mac/KeystoneGlue.m	View	1 2 3 4 5	1 chunk	+8 lines, -1 line	0 comments	Download
A	webkit/tools/test_shell/mac/TestShell.xcodeproj/package_test_shell.sh	View	1 2 3	1 chunk	+76 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/mac/TestShell.xcodeproj/project.pbxproj	View	1 2 3 4 5	7 chunks	+62 lines, -0 lines	0 comments	Download
A	webkit/tools/test_shell/mac/keystone_install.sh	View	1	1 chunk	+51 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jeremy

11 years, 11 months ago (2009-01-23 19:48:52 UTC) #2

lgtm

http://codereview.chromium.org/18521/diff/16/17
File webkit/tools/test_shell/mac/keystone_install.sh (right):

http://codereview.chromium.org/18521/diff/16/17#newcode28
Line 28: DEST=$(ksadmin -pP "${BUNDLE_ID}" | grep xc= | sed -E
's/.+path=(.+)>$/\1/g')
Ouch, I trust this does what it's supposed to do.
I hope we do the final version in Python :)

Expand Messages | Collapse Messages