Keystone auto-update support for TestShell

webkit/tools/test_shell/mac/KeystoneGlue.m

Index: webkit/tools/test_shell/mac/KeystoneGlue.m
===================================================================
--- webkit/tools/test_shell/mac/KeystoneGlue.m	(revision 8565)
+++ webkit/tools/test_shell/mac/KeystoneGlue.m	(working copy)
@@ -18,13 +18,20 @@
 
 @implementation KeystoneGlue
 
+// TODO(mmentovai): Determine if the app is writable, and don't register for
+// updates if not - but keep the periodic activity pings.
 + (void)registerWithKeystone {
   // Figure out who we are.
   NSBundle* mainBundle = [NSBundle mainBundle];
   NSString* bundleIdentifier = [mainBundle bundleIdentifier];
   NSDictionary* infoDictionary = [mainBundle infoDictionary];
   NSString* url = [infoDictionary objectForKey:@"KSUpdateURL"];
-  NSString* version = [infoDictionary objectForKey:(id)kCFBundleVersionKey];
+  // TODO(mmentovai): The svn version serves our purposes for now, but it will
+  // likely be replaced.  The key problem is that it does not monotonically
+  // increase for releases when considering svn branches and tags.  For the
+  // purposes of TestShell, though, which will likely only ever survive in
+  // auto-updatable form in builds straight from the trunk, this is fine.
+  NSString* version = [infoDictionary objectForKey:@"SVNRevision"];
   if (!bundleIdentifier || !url || !version) {
     // If parameters required for Keystone are missing, don't use it.
     return;