Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Unified Diff: chrome/common/unzip_unittest.cc

Issue 18499: Replace cases of Append(FILE_PATH_LITERAL()) with AppendASCII(""). (Closed)
Patch Set: Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/chrome_plugin_unittest.cc ('k') | net/base/ssl_test_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/unzip_unittest.cc
diff --git a/chrome/common/unzip_unittest.cc b/chrome/common/unzip_unittest.cc
index f572811c83482d256e1d5e3046044be62aad83bd..86cf824c85a1d9bf5be004d7fd1a16d5ee4f0c1f 100644
--- a/chrome/common/unzip_unittest.cc
+++ b/chrome/common/unzip_unittest.cc
@@ -24,17 +24,17 @@ class UnzipTest : public PlatformTest {
ASSERT_TRUE(file_util::CreateNewTempDirectory(
FILE_PATH_LITERAL("unzip_unittest_"), &test_dir_));
- FilePath zip_path(test_dir_.Append(FILE_PATH_LITERAL("test")));
+ FilePath zip_path(test_dir_.AppendASCII("test"));
zip_contents_.insert(zip_path);
- zip_contents_.insert(zip_path.Append(FILE_PATH_LITERAL("foo.txt")));
- zip_path = zip_path.Append(FILE_PATH_LITERAL("foo"));
+ zip_contents_.insert(zip_path.AppendASCII("foo.txt"));
+ zip_path = zip_path.AppendASCII("foo");
zip_contents_.insert(zip_path);
- zip_contents_.insert(zip_path.Append(FILE_PATH_LITERAL("bar.txt")));
- zip_path = zip_path.Append(FILE_PATH_LITERAL("bar"));
+ zip_contents_.insert(zip_path.AppendASCII("bar.txt"));
+ zip_path = zip_path.AppendASCII("bar");
zip_contents_.insert(zip_path);
- zip_contents_.insert(zip_path.Append(FILE_PATH_LITERAL("baz.txt")));
- zip_contents_.insert(zip_path.Append(FILE_PATH_LITERAL("quux.txt")));
- zip_path = zip_path.Append(FILE_PATH_LITERAL("baz"));
+ zip_contents_.insert(zip_path.AppendASCII("baz.txt"));
+ zip_contents_.insert(zip_path.AppendASCII("quux.txt"));
+ zip_path = zip_path.AppendASCII("baz");
zip_contents_.insert(zip_path);
}
@@ -48,7 +48,7 @@ class UnzipTest : public PlatformTest {
void TestZipFile(const FilePath::StringType& filename) {
FilePath test_dir;
ASSERT_TRUE(PathService::Get(chrome::DIR_TEST_DATA, &test_dir));
- test_dir = test_dir.Append(FILE_PATH_LITERAL("unzip"));
+ test_dir = test_dir.AppendASCII("unzip");
FilePath path = test_dir.Append(filename);
ASSERT_TRUE(file_util::PathExists(path)) << "no file " << path.value();
« no previous file with comments | « chrome/common/chrome_plugin_unittest.cc ('k') | net/base/ssl_test_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698