Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: src/regexp-macro-assembler-irregexp-inl.h

Issue 18363: * Irregexp: Move from a byte-oriented bytecode format to a 32-bit oriented... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/bytecodes-irregexp.h ('K') | « src/regexp-macro-assembler-irregexp.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/regexp-macro-assembler-irregexp-inl.h
===================================================================
--- src/regexp-macro-assembler-irregexp-inl.h (revision 1104)
+++ src/regexp-macro-assembler-irregexp-inl.h (working copy)
@@ -36,12 +36,14 @@
namespace v8 { namespace internal {
-void RegExpMacroAssemblerIrregexp::Emit(uint32_t byte) {
+void RegExpMacroAssemblerIrregexp::Emit(uint32_t byte, uint32_t twenty_four_bits) {
Christian Plesner Hansen 2009/01/20 14:22:17 Maybe assert that twenty_four_bits does indeed onl
Erik Corry 2009/01/20 18:49:55 Right now we don't check so the assert would not a
+ uint32_t word = ((twenty_four_bits << BYTECODE_SHIFT) | byte);
ASSERT(pc_ <= buffer_.length());
- if (pc_ == buffer_.length()) {
+ if (pc_ + 3 >= buffer_.length()) {
Expand();
}
- buffer_[pc_++] = byte;
+ Store32(buffer_.start() + pc_, word);
+ pc_ += 4;
}
« src/bytecodes-irregexp.h ('K') | « src/regexp-macro-assembler-irregexp.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698