* Irregexp: Move from a byte-oriented bytecode format to a 32-bit oriented...

src/regexp-macro-assembler-irregexp-inl.h

 // Copyright 2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 18 matching lines @@
 
 
 #include "v8.h"
 #include "ast.h"
 #include "bytecodes-irregexp.h"
 
 
 namespace v8 { namespace internal {
 
 
-void RegExpMacroAssemblerIrregexp::Emit(uint32_t byte) {
+void RegExpMacroAssemblerIrregexp::Emit(uint32_t byte, uint32_t twenty_four_bits) {

[Christian Plesner Hansen, 2009/01/20 14:22:17]

Maybe assert that twenty_four_bits does indeed only use 24 bits?

[Erik Corry, 2009/01/20 18:49:55]

Right now we don't check so the assert would not always be true (though it
always is for any sensible regexp).  I will add the assert when I add the check
(it's on the TODO list).

+  uint32_t word = ((twenty_four_bits << BYTECODE_SHIFT) | byte);
   ASSERT(pc_ <= buffer_.length());
-  if (pc_ == buffer_.length()) {
+  if (pc_  + 3 >= buffer_.length()) {
     Expand();
   }
-  buffer_[pc_++] = byte;
+  Store32(buffer_.start() + pc_, word);
+  pc_ += 4;
 }
 
 
 void RegExpMacroAssemblerIrregexp::Emit16(uint32_t word) {
   ASSERT(pc_ <= buffer_.length());
   if (pc_ + 1 >= buffer_.length()) {
     Expand();
   }
   Store16(buffer_.start() + pc_, word);
   pc_ += 2;
 }
 
 
 void RegExpMacroAssemblerIrregexp::Emit32(uint32_t word) {
   ASSERT(pc_ <= buffer_.length());
   if (pc_ + 3 >= buffer_.length()) {
     Expand();
   }
   Store32(buffer_.start() + pc_, word);
   pc_ += 4;
 }
 
 
 } }  // namespace v8::internal